mirror of
https://github.com/norandom/OpenUltraSAST.git
synced 2026-10-16 03:49:26 +00:00
feat(prover): delivery B: handler-named operations, Symfony, Livewire, Remix and Tornado entries, enforcement witnesses, memoised path walk
Codex delivery under spec access-control-prover plus one fix of mine. Operation rows may now name a handler by name pattern and framework (Jenkins form validation and list filling, Tornado request methods, Remix actions); the mapper recognises Symfony, Livewire and Laravel controllers, Remix exports and Tornado handlers; `obligations/enforcement.py` turns Laravel route middleware, Symfony attributes and security.yaml rules and Tornado's authenticated decorator into router and decorator witnesses. The path walk looks each node's callers up once per change and does not walk a tree with no recognised entry: one seatunnel change fell from 670 s to 35 s. One name Codex could not source (Tornado get_current_user) is left out and said so in the facts header. Smoke on the 23 fix changes: 15 pushes caught (65 percent, Wilson 45 to 81), 55 of 93 locations, precision 15 of 15 flagged, no instrument failure, no change over 120 s. Delivery A caught 7. Co-Authored-By: Claude Fable 5.1 <[email protected]>
This commit is contained in:
co-authored by
Claude Fable 5.1
parent
7f1b820d5a
commit
17e07b36c4
@@ -67,3 +67,175 @@ def test_jetty_servlet_and_jaxrs(tmp_path, text, name):
|
||||
|
||||
def test_unrecognised_and_comments(tmp_path):
|
||||
assert entries(tmp_path, "/* class X extends Descriptor { public void doFake() {} } */\nclass Plain { public void doCheck() {} }") == []
|
||||
|
||||
|
||||
def framework_entries(tmp_path, files):
|
||||
targets = []
|
||||
for name, text in files.items():
|
||||
path = tmp_path / name
|
||||
path.parent.mkdir(parents=True, exist_ok=True)
|
||||
path.write_text(text)
|
||||
targets.append(build_file_target(tmp_path, path))
|
||||
return [
|
||||
e for e in analyze_entry_points(tmp_path, targets, texts=files, include_manifests=False) if e.kind == "route" and e.function_name
|
||||
]
|
||||
|
||||
|
||||
@pytest.mark.parametrize("annotation", ['#[Route("/items")]', '/** @Route("/items") */'])
|
||||
def test_symfony_actions(tmp_path, annotation):
|
||||
rows = framework_entries(
|
||||
tmp_path,
|
||||
{
|
||||
"Controller.php": f"""<?php
|
||||
class Items extends AbstractController {{
|
||||
{annotation}
|
||||
public function show() {{ return 1; }}
|
||||
private function hidden() {{}}
|
||||
}}
|
||||
class Plain {{ public function helper() {{}} }}
|
||||
"""
|
||||
},
|
||||
)
|
||||
assert [e.function_name for e in rows] == ["show"]
|
||||
assert "Symfony" in " ".join(rows[0].access_evidence)
|
||||
assert "/items" in " ".join(rows[0].access_evidence)
|
||||
|
||||
|
||||
def test_livewire_public_methods_and_bindings(tmp_path):
|
||||
rows = framework_entries(
|
||||
tmp_path,
|
||||
{
|
||||
"Component.php": """<?php
|
||||
use Livewire\\Component;
|
||||
class Editor extends Component {
|
||||
public function store() {}
|
||||
public function _helper() {}
|
||||
protected function hidden() {}
|
||||
}
|
||||
class Other { public function store() {} }
|
||||
""",
|
||||
"view.blade.php": '<button wire:click="store">Save</button>',
|
||||
},
|
||||
)
|
||||
assert [(e.path, e.function_name) for e in rows] == [("Component.php", "store")]
|
||||
assert "Livewire" in " ".join(rows[0].access_evidence)
|
||||
|
||||
|
||||
@pytest.mark.parametrize("middleware,access", [("", "public"), ("->middleware(['auth', 'can:edit'])", "unknown")])
|
||||
def test_laravel_cross_file_registration(tmp_path, middleware, access):
|
||||
rows = framework_entries(
|
||||
tmp_path,
|
||||
{
|
||||
"app/Http/Controllers/Editor.php": """<?php
|
||||
class Editor extends Controller {
|
||||
public function store() {}
|
||||
public function helper() {}
|
||||
}
|
||||
class Other extends Controller { public function store() {} }
|
||||
""",
|
||||
"routes/web.php": f"<?php Route::post('/items', [Editor::class, 'store']){middleware};",
|
||||
},
|
||||
)
|
||||
assert [(e.function_name, e.access_level) for e in rows] == [("store", access)]
|
||||
assert rows[0].path == "app/Http/Controllers/Editor.php"
|
||||
assert "Laravel" in " ".join(rows[0].access_evidence)
|
||||
|
||||
|
||||
def test_symfony_route_config(tmp_path):
|
||||
rows = framework_entries(
|
||||
tmp_path,
|
||||
{
|
||||
"Controller.php": "<?php class Editor extends AbstractController { public function show() {} public function helper() {} }",
|
||||
"config/routes.yaml": "items:\n path: /items\n controller: App\\Controller\\Editor::show\n",
|
||||
},
|
||||
)
|
||||
assert [e.function_name for e in rows] == ["show"]
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
"declaration",
|
||||
[
|
||||
"export async function action() { return 1; }",
|
||||
"export const action = async () => { return 1; }",
|
||||
"export const action: ActionFunction = async () => { return 1; }",
|
||||
],
|
||||
)
|
||||
def test_remix_exports(tmp_path, declaration):
|
||||
rows = framework_entries(tmp_path, {"apps/web/app/routes/items.ts": declaration + "\nexport function loader() { return 1; }"})
|
||||
assert [e.function_name for e in rows] == ["action", "loader"]
|
||||
assert all("Remix" in " ".join(e.access_evidence) and e.access_level == "unknown" for e in rows)
|
||||
assert framework_entries(tmp_path, {"app/helpers/items.ts": declaration}) == []
|
||||
|
||||
|
||||
@pytest.mark.parametrize("base", ["tornado.web.RequestHandler", "tornado.websocket.WebSocketHandler", "RequestHandler"])
|
||||
def test_tornado_methods(tmp_path, base):
|
||||
rows = framework_entries(
|
||||
tmp_path,
|
||||
{
|
||||
"app.py": f"""from tornado.web import RequestHandler
|
||||
class Handler({base}):
|
||||
def get(self):
|
||||
return 1
|
||||
def open(self):
|
||||
pass
|
||||
def helper(self):
|
||||
pass
|
||||
class Plain:
|
||||
def get(self):
|
||||
pass
|
||||
"""
|
||||
},
|
||||
)
|
||||
assert [e.function_name for e in rows] == ["get", "open"]
|
||||
assert all("Tornado" in " ".join(e.access_evidence) for e in rows)
|
||||
|
||||
|
||||
@pytest.mark.parametrize("prefix", ["", "\n" * 320])
|
||||
def test_symfony_named_paths_and_class_prefix(tmp_path, prefix):
|
||||
rows = framework_entries(
|
||||
tmp_path,
|
||||
{
|
||||
"Controller.php": prefix
|
||||
+ """<?php
|
||||
/** @Route(path="/admin") */
|
||||
class Editor extends AbstractController {
|
||||
/** @Route(path="/items") */
|
||||
public function show() {}
|
||||
}
|
||||
"""
|
||||
},
|
||||
)
|
||||
assert [row.name for row in rows] == ["/admin/items"]
|
||||
assert rows[0].line == 5 + prefix.count("\n")
|
||||
|
||||
|
||||
def test_tornado_inherited_and_explicit_super_handler(tmp_path):
|
||||
rows = framework_entries(
|
||||
tmp_path,
|
||||
{
|
||||
"app.py": """import tornado.websocket
|
||||
import terminado
|
||||
class Base(tornado.websocket.WebSocketHandler):
|
||||
pass
|
||||
class Child(Base):
|
||||
def open(self):
|
||||
pass
|
||||
class Terminal(terminado.TermSocket):
|
||||
def open(self):
|
||||
tornado.websocket.WebSocketHandler.open(self)
|
||||
"""
|
||||
},
|
||||
)
|
||||
assert [row.function_name for row in rows] == ["open", "open"]
|
||||
|
||||
|
||||
def test_remix_tsx_with_jsx(tmp_path):
|
||||
rows = framework_entries(
|
||||
tmp_path,
|
||||
{
|
||||
"app/routes/items.tsx": """export const action = async () => { return 1; };
|
||||
export default function Items() { return <div>Items</div>; }
|
||||
"""
|
||||
},
|
||||
)
|
||||
assert [row.function_name for row in rows] == ["action"]
|
||||
|
||||
Reference in New Issue
Block a user