mirror of
https://github.com/norandom/OpenUltraSAST.git
synced 2026-10-16 03:49:26 +00:00
search-with-proof: executor smoke driver and pilot selection (6.1)
20 development pairs, one per repository, 4 per language, 5 per family; identities in a gitignored manifest, counts and digest committed. Executor smoke drives one executor task end to end without a model and fails loudly on an unread clone. kube-ax operator constraints as steering. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
85f4f0b3d4
commit
1d67412e2b
@@ -0,0 +1,162 @@
|
||||
"""No-network end-to-end executor smoke, through the real mailbox client."""
|
||||
|
||||
import json
|
||||
import sys
|
||||
import time
|
||||
from pathlib import Path
|
||||
from types import SimpleNamespace
|
||||
|
||||
import pytest
|
||||
|
||||
sys.path.insert(0, str(Path(__file__).resolve().parents[1]))
|
||||
|
||||
from benchmarks.ax import batch
|
||||
from benchmarks.search import executor_smoke as smoke
|
||||
from openultrasast.search.executor import Command, InProcessExecutor
|
||||
|
||||
|
||||
class Store:
|
||||
def __init__(self, executor):
|
||||
self.executor, self.objects = executor, {}
|
||||
|
||||
def _put(self, key, data):
|
||||
self.objects[key] = data
|
||||
|
||||
def _delete(self, key):
|
||||
self.objects.pop(key, None)
|
||||
|
||||
def presign_get(self, key, expires):
|
||||
return "https://files.example/" + key
|
||||
|
||||
presign_put = presign_get
|
||||
|
||||
def put(self, url, data, timeout):
|
||||
self.result = json.dumps(self.executor.execute(Command(**json.loads(data)))).encode()
|
||||
|
||||
def get(self, url, timeout):
|
||||
return self.result
|
||||
|
||||
|
||||
class Executor(InProcessExecutor):
|
||||
empty = False
|
||||
empty_install = False
|
||||
|
||||
def _task_run(self, argv, timeout, limits):
|
||||
if argv[:2] == ["sh", "-ec"]:
|
||||
if not self.empty:
|
||||
(self.repo / "README.md").write_text("test input")
|
||||
(self.repo / "requirements.txt").write_text("")
|
||||
return dict(exit_code=0, stdout="cloned", stderr="", scratch_peak_bytes=4096, stdout_bytes=6, stderr_bytes=0)
|
||||
if "pip" in argv:
|
||||
return dict(
|
||||
exit_code=0,
|
||||
stdout="" if self.empty_install else "installed",
|
||||
stderr="",
|
||||
scratch_peak_bytes=8192,
|
||||
stdout_bytes=0 if self.empty_install else 9,
|
||||
stderr_bytes=0,
|
||||
)
|
||||
return super()._task_run(argv, timeout, limits)
|
||||
|
||||
|
||||
def setup(tmp_path, monkeypatch):
|
||||
executor = Executor(tmp_path, task_boundary=True)
|
||||
store = Store(executor)
|
||||
monkeypatch.setattr("openultrasast.search.executor.URLTransport", lambda: store)
|
||||
events = []
|
||||
lane = SimpleNamespace(
|
||||
store=store,
|
||||
host="files.example",
|
||||
args=SimpleNamespace(atespace="default"),
|
||||
workload=batch.Workload("image@sha256:" + "a" * 64, frozenset(), 900, None),
|
||||
clock=time.monotonic,
|
||||
)
|
||||
|
||||
def ax(*args, **kwargs):
|
||||
events.append(args[0])
|
||||
if args[0] == "apply":
|
||||
doc = kwargs["manifest"]
|
||||
assert doc["metadata"]["name"].startswith("ousast-engine-search-exec-")
|
||||
assert {x["name"] for x in doc["spec"]["env"]} == {"REPO_URL", "COMMAND_GET_URL", "EXECUTOR_RESULT_PUT_URL", "PREPARED_PUT_URL"}
|
||||
|
||||
lane.ax = ax
|
||||
return executor, lane, events
|
||||
|
||||
|
||||
def test_smoke_mailbox_end_to_end(tmp_path, monkeypatch):
|
||||
executor, lane, events = setup(tmp_path, monkeypatch)
|
||||
record = smoke.run_smoke(lane, "https://github.com/example/project", "a" * 40)
|
||||
assert record["status"] == "ok"
|
||||
assert executor.stopped
|
||||
assert events == ["apply", "delete"]
|
||||
assert not lane.store.objects
|
||||
assert [r["step"] for r in record["commands"]] == ["clone", "list_files", "read_file", "grep", "install", "trivial", "stop"]
|
||||
assert record["scratch_peak_bytes"] >= 8192
|
||||
read = next(r for r in record["commands"] if r["step"] == "read_file")
|
||||
assert read["input_bytes"] == 10
|
||||
assert all(r["wall_seconds"] >= 0 and r["output_bytes"] >= 0 for r in record["commands"])
|
||||
|
||||
|
||||
@pytest.mark.parametrize("kind,reason", [("empty", "clone yielded zero files"), ("empty_install", "empty fast install")])
|
||||
def test_instrument_failure_and_cleanup(tmp_path, monkeypatch, kind, reason):
|
||||
executor, lane, events = setup(tmp_path, monkeypatch)
|
||||
setattr(executor, kind, True)
|
||||
record = smoke.run_smoke(lane, "https://github.com/example/project", "a" * 40)
|
||||
assert record["status"] == "instrument_failure"
|
||||
assert reason in record["reason"]
|
||||
assert events[-1] == "delete"
|
||||
assert not lane.store.objects
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
"files,recipe", [(["package.json"], "npm"), (["composer.json"], "composer"), (["pom.xml"], "maven"), (["pyproject.toml"], "pip")]
|
||||
)
|
||||
def test_recipes(files, recipe):
|
||||
assert smoke.install_recipe(files)[0] == recipe
|
||||
|
||||
|
||||
def test_real_executor_measurements(tmp_path):
|
||||
(tmp_path / "input").write_bytes(b"12345")
|
||||
result = InProcessExecutor(tmp_path, task_boundary=True).submit("run", {"command": ["python3", "-c", "print(1)"]})
|
||||
assert result["exit_code"] == 0
|
||||
assert result["stdout_bytes"] == 2
|
||||
assert result["scratch_peak_bytes"] >= 5
|
||||
assert result["wall_seconds"] > 0
|
||||
|
||||
|
||||
def test_docker_managed_task_uses_docker_and_no_heap_flag(tmp_path, monkeypatch):
|
||||
import subprocess
|
||||
|
||||
executor = Executor(tmp_path, task_boundary=True)
|
||||
store = Store(executor)
|
||||
monkeypatch.setattr("openultrasast.search.executor.URLTransport", lambda: store)
|
||||
monkeypatch.setenv("S3_ENDPOINT", "https://files.example")
|
||||
calls = []
|
||||
|
||||
def runner(argv, **kwargs):
|
||||
calls.append(argv)
|
||||
return subprocess.CompletedProcess(argv, 0, "", "")
|
||||
|
||||
lane = batch.DockerLane(
|
||||
SimpleNamespace(atespace="default"), batch.Workload("image@sha256:" + "a" * 64, frozenset(), 900, None), store=store, runner=runner
|
||||
)
|
||||
record = smoke.run_smoke(lane, "https://github.com/example/project", "a" * 40)
|
||||
assert record["status"] == "ok"
|
||||
assert [a[1] for a in calls] == ["run", "rm"]
|
||||
assert "--heap-profile" not in calls[0]
|
||||
assert calls[1][2] == "-f"
|
||||
|
||||
|
||||
def test_apply_exception_still_deletes(tmp_path, monkeypatch):
|
||||
executor, lane, events = setup(tmp_path, monkeypatch)
|
||||
|
||||
def failing(*args, **kwargs):
|
||||
events.append(args[0])
|
||||
if args[0] == "apply":
|
||||
raise OSError("do not expose https://secret.example/token")
|
||||
|
||||
lane.ax = failing
|
||||
result = smoke.run_smoke(lane, "https://github.com/example/project", "a" * 40)
|
||||
assert result["status"] == "instrument_failure"
|
||||
assert events == ["apply", "delete"]
|
||||
assert "secret.example" not in json.dumps(result)
|
||||
Reference in New Issue
Block a user