mirror of
https://github.com/norandom/OpenUltraSAST.git
synced 2026-10-16 03:49:26 +00:00
bench(pairs): real fix-commit pairs for the short families
97 advisory-fix pairs, one repository each (309 advisories examined, 212 rejected with reasons in research-2026-10-01.md): a public fix commit distinct from its parent, the advisory-named function declared on both sides with a changed body. Pointer pairs: materialize.py reads one file per side from a shallow blobless fetch into the pair cache and verifies them with the label builder's matcher (verification.json, bytes read). learn/sources.toml lists the catalog as the advisory-fixes source. Label snapshot: negative repository groups untrusted_destination 8->25, path 3->21, output_encoding 1->22, deserialization 0->21, access_control 0->20; all five reach the per-family floor. Five pairs on reserved repositories were dropped after the reserved-population guard flagged them. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01EmM1j46qgKMh3zqD1QMwEo
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
658f2d5e39
commit
53c9a7cc65
@@ -0,0 +1,88 @@
|
||||
"""The advisory-fix pair catalog: real fixes only, read by the label builder, recorded as verified, never a repeat.
|
||||
|
||||
Offline. The two sides live in the pair cache (``benchmarks/pairs/advisory-fixes/materialize.py --fetch``); what is
|
||||
committed is the catalog and ``verification.json``, the per-pair record of that script's check (the function is
|
||||
declared on both sides, its body changed, bytes read). These tests hold the catalog to that record.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import json
|
||||
import re
|
||||
import tomllib
|
||||
from collections import Counter
|
||||
from pathlib import Path
|
||||
|
||||
from openultrasast.learn.labels import DEFAULT_SOURCES, load_sources, repo_name
|
||||
from openultrasast.model.taxonomy import load_families
|
||||
from openultrasast.pairs import load_pair_catalog
|
||||
|
||||
ROOT = Path(__file__).resolve().parents[1]
|
||||
FOLDER = ROOT / "benchmarks" / "pairs" / "advisory-fixes"
|
||||
CATALOG = FOLDER / "catalog.toml"
|
||||
SHA = re.compile(r"[0-9a-f]{40}")
|
||||
PERMISSIVE_OR_COPYLEFT = re.compile(
|
||||
r"^(MIT|BSD-[23]-Clause|Apache-2\.0|ISC|Zlib|0BSD|Unlicense|MPL-[12]\.[01]"
|
||||
r"|(L|A)?GPL-[23]\.0(-only|-or-later)?|EPL-2\.0)$"
|
||||
)
|
||||
GITHUB = re.compile(r"github\.com/([A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+)", re.IGNORECASE)
|
||||
|
||||
|
||||
def _raw() -> list[dict]:
|
||||
return list(tomllib.loads(CATALOG.read_text())["pair"])
|
||||
|
||||
|
||||
def test_every_pair_is_a_real_fix_with_its_function_licence_and_advisory() -> None:
|
||||
families = {family.id for family in load_families().families}
|
||||
for item in _raw():
|
||||
name = item["name"]
|
||||
assert SHA.fullmatch(item["commit"]) and SHA.fullmatch(item["parent"]), name
|
||||
assert item["commit"] != item["parent"], f"{name}: the fix commit is its own parent"
|
||||
assert item["commit_url"] == f"https://github.com/{item['repo']}/commit/{item['commit']}", name
|
||||
assert PERMISSIVE_OR_COPYLEFT.match(item["license"]), f"{name}: licence {item['license']!r} is not an SPDX id"
|
||||
assert re.search(r"CVE-\d{4}-\d+|GHSA-", item["cve"]), f"{name}: no advisory id"
|
||||
(row,) = item["expected"]
|
||||
assert row["function"] and row["path"] == item["path"] and row["family"] in families, name
|
||||
assert item["vendored"] is False and item["slice"] == "advisory-fixes", name
|
||||
|
||||
|
||||
def test_the_catalog_loads_as_pointer_pairs_one_repository_each() -> None:
|
||||
cases = load_pair_catalog(CATALOG)
|
||||
assert len(cases) == len(_raw()) and all(not case.vendored for case in cases)
|
||||
repos = Counter(repo_name(case.repo) for case in cases)
|
||||
assert [repo for repo, n in repos.items() if n > 1] == [], "one pair per repository"
|
||||
|
||||
|
||||
def test_the_label_builder_lists_the_catalog_as_a_source() -> None:
|
||||
sources = load_sources(DEFAULT_SOURCES)
|
||||
source = sources.get("advisory-fixes")
|
||||
assert source.kind == "pairs" and source.files == ("benchmarks/pairs/advisory-fixes/catalog.toml",)
|
||||
assert all((ROOT / path).is_file() for path in source.evaluation)
|
||||
|
||||
|
||||
def test_every_pair_was_verified_on_both_sides() -> None:
|
||||
record = json.loads((FOLDER / "verification.json").read_text())
|
||||
rows = {row["name"]: row for row in record["pairs"]}
|
||||
for item in _raw():
|
||||
row = rows.get(item["name"])
|
||||
assert row is not None and row["ok"], f"{item['name']}: not verified ({row and row.get('reason')})"
|
||||
assert row["bytes_read"] > 0, f"{item['name']}: verified without reading anything"
|
||||
assert set(rows) == {item["name"] for item in _raw()}
|
||||
|
||||
|
||||
def test_no_pair_repeats_a_repository_the_benchmarks_already_name() -> None:
|
||||
"""A repository group is counted once: no catalog repository appears anywhere else under benchmarks/ (files the
|
||||
label sources exclude, the reserved v3 population among them, are skipped by name and never opened)."""
|
||||
excluded = load_sources(DEFAULT_SOURCES).excluded
|
||||
ours = {repo_name(item["repo"]) for item in _raw()}
|
||||
elsewhere: set[str] = set()
|
||||
for path in (ROOT / "benchmarks").rglob("*"):
|
||||
if not path.is_file() or FOLDER in path.parents or path.name in excluded or path.suffix in {".pyc", ".bin", ".gz", ".jsonl"}:
|
||||
continue
|
||||
try:
|
||||
text = path.read_text(errors="ignore")
|
||||
except OSError:
|
||||
continue
|
||||
elsewhere |= {repo_name(match) for match in GITHUB.findall(text)}
|
||||
elsewhere |= {repo_name(m) for m in re.findall(r'^\s*(?:repo|fix_repo)\s*=\s*"([^"]+)"', text, re.MULTILINE)}
|
||||
assert sorted(ours & elsewhere) == []
|
||||
Reference in New Issue
Block a user