marius/Open_Ultra_SAST
1
0
Fork 0
mirror of https://github.com/norandom/OpenUltraSAST.git synced 2026-10-16 03:49:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(cpg): read /proc state without a check-then-read race

Browse Source 
`test_hanging_process_group_killed_inside_shared_allowance` failed about one
run in thirty under load with FileNotFoundError: it checked that
/proc/<pid>/stat existed, the killed process was reaped, and the read then
failed. A reaped process is the outcome the test wants, so it now reads and
treats a missing entry as gone. The engine-stage test had the same race.
150 of 150 runs pass under engine load.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01EmM1j46qgKMh3zqD1QMwEo
This commit is contained in:
Marius Ciepluch
2026-09-23 14:03:48 +02:00
co-authored by Claude Opus 5.5
parent 0bcaabfbed
commit 9b47e2c345
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_cpg_budget.py
+10 -2
View File
@@ -67,7 +67,12 @@ while True: time.sleep(1)
for pid in map(int, pids.read_text().split()):
status = Path(f"/proc/{pid}/stat")
for _ in range(30):
if not status.exists() or status.read_text().split()[2] == "Z":
# Read, never check-then-read: a killed process can be reaped between the two, and its
# disappearing is exactly the outcome this test wants, not an error.
try:
if status.read_text().split()[2] == "Z":
break
except FileNotFoundError:
break
time.sleep(0.005)
else:
@@ -147,7 +152,10 @@ print({END!r})
for pid in map(int, pid_log.read_text().split()):
status = Path(f"/proc/{pid}/stat")
for _ in range(30):
if not status.exists() or status.read_text().split()[2] == "Z":
try: # read, never check-then-read: a reaped process is the outcome wanted
if status.read_text().split()[2] == "Z":
break
except FileNotFoundError:
break
time.sleep(0.005)
else: