feat(model-grounded-detection): group 1, subtract the noise architecture

99 source modules -> 81. 832 tests -> 646. The whole learning/ package (16
modules, ~4,100 lines) and six semantic/ modules removed, with the three gates
byte-identical to 2026-09-06-gate-baseline.txt at every step.

The sequence is what made it safe: vocabularies ported first (1.1), importers
detached second (1.2-1.3), deletion third (1.4). Every import break during the
deletion was therefore a detachment miss in the importer and was fixed there --
no module was restored to satisfy one. Both misses were the same shape and were
fixed as a class: operations.py and shapes.py each imported trailing_name from
the deleted variants.py, so it moved to semantic/ir.py, its natural home, and
both importers changed in one edit.

Ported before deleting: the closed guard vocabulary (verbatim, nothing else
holds it) into model/specs.py, which derives TaintSpec and DominanceSpec from
the retained ruleset facts rather than copying them. Re-homed: families ->
model/taxonomy, candidates -> model/candidates, endpoint -> model/endpoint,
plus Region, labeled_family and labeled_spans. labeled_family no longer falls
back to the LLM classifier -- an unlabeled pair is honestly unknown.

Four deviations, each recorded in the spec notes with its reason. improve/
evolve.py and validator.py were stripped, not deleted: each mixes the mechanism
lever (gone) with the deterministic rule-status loop `ousast improve` still
runs, which has no LLM in it; a test now asserts the lever's absence by symbol
so it cannot creep back. The learning CLI group became `model candidates`,
because deleting it outright would have orphaned the retained enumerator by
removing its only entry point. thinking moved from [learning] to [models].

A gap named rather than papered over: no retained sink fact routes by CWE to
path, output_encoding, untrusted_destination or prototype -- the same hole the
entailment ceiling diagnosed. The test asserts the seeded set and the gap set
exactly, so task 4.2 must update it when it authors those sinks.

The audit found exactly one genuine orphan: vectorstore.py, a bakeoff harness
with no production caller and no CLI, alive only through its own test. The five
named subsystems each carry an explicit decision. Manifest committed, with a
test asserting the tree still matches it.

Group 2 (the Joern go/no-go) has not started.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01T7XD7x5KonMdmGRkp63EQG
This commit is contained in:
Marius Ciepluch
2026-09-08 12:15:54 +02:00
co-authored by Claude Opus 5
parent fc4dab97fb
commit 9ed0e45c5f
86 changed files with 1710 additions and 12158 deletions
+189
View File
@@ -0,0 +1,189 @@
"""The closed family taxonomy (learning-harness, Req 1).
Ten families, loaded from ``ruleset/families.toml``. A family is the only key that routes work and
scores a pair: CWE ids and mechanism ids are attributes reached *through* a family, so no caller may
group by them. Every family names what can verify a claim in it (a sandbox canary, static
corroboration, or nothing), which is what keeps reporting honest one layer up. An unknown field, a
family outside the closed set, a missing verifier kind or a CWE claimed twice is a data bug and fails
loud, naming the offender.
"""
from __future__ import annotations
import tomllib
from dataclasses import dataclass
from pathlib import Path
from typing import Literal
FAMILY_IDS = (
"injection",
"path",
"deserialization",
"access_control",
"output_encoding",
"untrusted_destination",
"prototype",
"config_secrets",
"memory",
"unknown",
)
VERIFIER_KINDS = ("canary", "static", "none")
Relation = Literal["same", "parent_child", "lateral", "fabricated"]
DEFAULT_FAMILIES_PATH = Path(__file__).resolve().parents[1] / "ruleset" / "families.toml"
_FAMILY_FIELDS = frozenset({"id", "description", "cwes", "mechanisms", "verifier", "parent"})
_TOP_FIELDS = frozenset({"version", "family"})
class FamiliesError(ValueError):
"""Raised when the taxonomy file names a family, field, verifier or CWE outside the closed sets."""
@dataclass(frozen=True)
class Family:
id: str # FAMILY_IDS
description: str
cwes: frozenset[str]
mechanisms: frozenset[str]
verifier: str # VERIFIER_KINDS
parent: str | None = None # a family this one specializes; partial credit when one side is the other's parent
@dataclass(frozen=True)
class FamilyTaxonomy:
version: str
families: tuple[Family, ...]
def by_id(self, family_id: str) -> Family:
for family in self.families:
if family.id == family_id:
return family
raise FamiliesError(f"unknown family {family_id!r}; expected one of {', '.join(f.id for f in self.families)}")
def family_of_cwe(self, cwe: str) -> Family | None:
"""The family that claims this CWE, or None when nobody has placed it yet (a data gap, not `unknown`)."""
token = cwe.strip().upper()
return next((family for family in self.families if token in family.cwes), None)
def family_of_mechanism(self, mechanism: str) -> Family | None:
return next((family for family in self.families if mechanism in family.mechanisms), None)
@property
def hierarchical(self) -> bool:
"""True when some family declares a parent. While this is False, partial credit can never be earned."""
return any(family.parent for family in self.families)
def related(self, left: str, right: str) -> Relation:
"""How two family answers relate. Abstention is not partial credit: ``unknown`` against a real
family is ``lateral``, never ``parent_child``."""
known = {family.id: family for family in self.families}
if left not in known or right not in known:
return "fabricated"
if left == right:
return "same"
if known[left].parent == right or known[right].parent == left:
return "parent_child"
return "lateral"
def load_families(path: Path | None = None, *, require_all: bool = True) -> FamilyTaxonomy:
"""Load the taxonomy. ``require_all`` demands the full closed set in order (the shipped file);
a scoped fixture may declare a subset, but never a family outside ``FAMILY_IDS``."""
source = path if path is not None else DEFAULT_FAMILIES_PATH
try:
payload = tomllib.loads(source.read_text(encoding="utf-8"))
except OSError as exc:
raise FamiliesError(f"families file unreadable: {source}") from exc
except tomllib.TOMLDecodeError as exc:
raise FamiliesError(f"families file is not valid TOML: {source}: {exc}") from exc
unknown_top = sorted(set(payload) - _TOP_FIELDS)
if unknown_top:
raise FamiliesError(f"{source}: unknown top-level field(s) {', '.join(unknown_top)}")
version = str(payload.get("version", "")).strip()
if not version:
raise FamiliesError(f"{source}: version is required")
families: list[Family] = []
claimed: dict[str, str] = {}
claimed_mechanisms: dict[str, str] = {}
for entry in payload.get("family", []):
if not isinstance(entry, dict):
raise FamiliesError(f"{source}: every [[family]] entry must be a table")
family = _family(source, entry)
if any(existing.id == family.id for existing in families):
raise FamiliesError(f"{source}: family {family.id!r} declared twice")
for cwe in sorted(family.cwes):
if cwe in claimed:
raise FamiliesError(f"{source}: {cwe} is claimed by both {claimed[cwe]!r} and {family.id!r}")
claimed[cwe] = family.id
for mechanism in sorted(family.mechanisms):
if mechanism in claimed_mechanisms:
raise FamiliesError(
f"{source}: mechanism {mechanism} is claimed by both {claimed_mechanisms[mechanism]!r} and {family.id!r}"
)
claimed_mechanisms[mechanism] = family.id
families.append(family)
_check_parents(source, families)
if require_all and tuple(family.id for family in families) != FAMILY_IDS:
raise FamiliesError(f"{source}: expected exactly {', '.join(FAMILY_IDS)} in that order, got {', '.join(f.id for f in families)}")
if not families:
raise FamiliesError(f"{source}: no families declared")
return FamilyTaxonomy(version=version, families=tuple(families))
def _family(source: Path, entry: dict[str, object]) -> Family:
unknown_fields = sorted(set(entry) - _FAMILY_FIELDS)
if unknown_fields:
raise FamiliesError(f"{source}: family {entry.get('id')!r} has unknown field(s) {', '.join(unknown_fields)}")
family_id = str(entry.get("id", "")).strip()
if family_id not in FAMILY_IDS:
raise FamiliesError(f"{source}: unknown family {family_id!r}; expected one of {', '.join(FAMILY_IDS)}")
verifier = str(entry.get("verifier", "")).strip()
if verifier not in VERIFIER_KINDS:
raise FamiliesError(f"{source}: family {family_id!r} has verifier {verifier!r}; expected one of {', '.join(VERIFIER_KINDS)}")
description = str(entry.get("description", "")).strip()
if not description:
raise FamiliesError(f"{source}: family {family_id!r} needs a description")
cwes = _tokens(source, family_id, entry.get("cwes", ()), "cwes", upper=True)
mechanisms = _tokens(source, family_id, entry.get("mechanisms", ()), "mechanisms")
parent = entry.get("parent")
return Family(
id=family_id,
description=description,
cwes=frozenset(cwes),
mechanisms=frozenset(mechanisms),
verifier=verifier,
parent=str(parent) if parent else None,
)
def _tokens(source: Path, family_id: str, value: object, field: str, *, upper: bool = False) -> list[str]:
if not isinstance(value, list) or any(not isinstance(item, str) for item in value):
raise FamiliesError(f"{source}: family {family_id!r} field {field} must be a list of strings")
tokens = [item.strip().upper() if upper else item.strip() for item in value]
duplicates = sorted({token for token in tokens if tokens.count(token) > 1})
if duplicates:
raise FamiliesError(f"{source}: family {family_id!r} lists {', '.join(duplicates)} twice in {field}")
return tokens
def _check_parents(source: Path, families: list[Family]) -> None:
ids = {family.id for family in families}
for family in families:
if family.parent is None:
continue
if family.parent not in ids:
raise FamiliesError(f"{source}: family {family.id!r} declares unknown parent {family.parent!r}")
if family.parent == family.id:
raise FamiliesError(f"{source}: family {family.id!r} is its own parent")
__all__ = [
"DEFAULT_FAMILIES_PATH",
"FAMILY_IDS",
"VERIFIER_KINDS",
"FamiliesError",
"Family",
"FamilyTaxonomy",
"Relation",
"load_families",
]