perf(model): one Joern invocation per query kind, not one per region

JVM startup dominated a scan: a call per region per family put a ten-line
file at 275s over three regions, and would have put a thousand regions at
roughly fifty hours. The queries themselves are milliseconds once the CPG
is loaded, so the cost was almost entirely process starts.

scan_repository() is now collect -> batch -> arbitrate. The three .sc
scripts accept a `requests` JSON map and answer all of them in one run,
keeping the single-request form so the committed measurements stay
reproducible byte-for-byte. Arbiters are untouched: each is handed a
CpgResult whose `run` returns its own prefetched rows.

The batcher builds parameters by calling request_params() extracted from
taint.py, dominance.py and config_value.py rather than reconstructing
them. A second copy that drifts from the arbiter's is the exact shape of
the five family-assumption bugs the predecessor spec spent a session
finding; there is now one definition per family and the batcher borrows
it.

Regions are also deduplicated by (path, function), collapsing the
nameless entry-point rows that were producing `model:injection:?:10`.

Measured on the same ten-line file: 275s -> 106s, three duplicate
findings -> one `model:injection:ping:10`, rung unchanged at
model_entailed. Gates byte-identical.

Server mode is recorded as task 2.3, deliberately sequenced after the
repository measurement: whether the remaining ~100s floor is worth a
process model, a weakened subprocess seam and a Scala-evaluating HTTP
endpoint depends on a build-time-to-query-time ratio only 2.2 produces.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01T7XD7x5KonMdmGRkp63EQG

tests/test_cpg_backend.py

@@ -105,3 +105,60 @@ def test_the_query_scripts_are_shipped_beside_the_seam() -> None:
     """The CPGQL is ours and is data: it lives with the package, not inlined in a Python string."""
     queries = Path("src/openultrasast/cpg/queries")
     assert (queries / "taint.sc").is_file(), "the injection taint query must ship with the package"
+
+
+def test_a_batch_is_one_invocation_carrying_many_requests(monkeypatch: pytest.MonkeyPatch) -> None:
+    """The cost that dominates a repository scan is JVM startup, not CPG construction.
+
+    Every `joern --script` call starts a JVM (~30s). The driver issued one per region per family, so a
+    ten-line Python file -- six families, one region -- took over four minutes, and 1000 regions would take
+    ~50 hours. Batching collapses that to one invocation per query kind.
+    """
+    from openultrasast.cpg.backend import BEGIN, END, JoernBackend
+
+    calls: list[list[str]] = []
+
+    class _Done:
+        returncode = 0
+        stderr = ""
+        stdout = f'{BEGIN}\n{{"r1": [{{"sink": "os.system(x)"}}], "r2": []}}\n{END}\n'
+
+    def runner(command, **kwargs):  # type: ignore[no-untyped-def]
+        calls.append(list(command))
+        return _Done()
+
+    backend = JoernBackend(runner=runner)
+    rows = backend.query_batch(
+        Path("/tmp/c.bin"),
+        "taint",
+        {"r1": {"sources": ("request.args",), "sinks": ("os.system",)}, "r2": {"sources": ("request.args",), "sinks": ("eval",)}},
+    )
+    assert len(calls) == 1, "a batch must be ONE invocation, whatever it carries"
+    assert rows["r1"] and rows["r2"] == []
+
+
+def test_a_failed_batch_yields_no_rows_for_any_request(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Fail closed, as everywhere else: an engine that could not answer must not read as 'nothing here'."""
+    from openultrasast.cpg.backend import JoernBackend
+
+    class _Bad:
+        returncode = 1
+        stdout = ""
+        stderr = "boom"
+
+    backend = JoernBackend(runner=lambda c, **k: _Bad())
+    assert backend.query_batch(Path("/tmp/c.bin"), "taint", {"r1": {}}) == {}
+
+
+def test_a_batch_result_that_omits_a_request_returns_nothing_for_it() -> None:
+    """A missing key is not an empty answer: the caller must be able to tell them apart."""
+    from openultrasast.cpg.backend import BEGIN, END, JoernBackend
+
+    class _Partial:
+        returncode = 0
+        stderr = ""
+        stdout = f'{BEGIN}\n{{"r1": []}}\n{END}\n'
+
+    backend = JoernBackend(runner=lambda c, **k: _Partial())
+    rows = backend.query_batch(Path("/tmp/c.bin"), "taint", {"r1": {}, "r2": {}})
+    assert rows.get("r1") == [] and "r2" not in rows

tests/test_model_regions.py

@@ -116,3 +116,37 @@ def test_an_unsupported_language_yields_no_region() -> None:
     from openultrasast.model.regions import regions_for
 
     assert regions_for([], [_target(path="x.rb", language="ruby")]) == ()
+
+
+def test_nameless_entry_points_do_not_duplicate_a_file_already_covered() -> None:
+    """The mapper can emit several entry points for one file, some with no function name.
+
+    On a ten-line Flask file it produced three: `ping`, and two nameless ones. Turning each into a region
+    scanned the same file three times and multiplied the Joern invocations by three for no new coverage.
+    A nameless entry point is the file; if a named region already covers that file, it adds nothing.
+    """
+    from openultrasast.model.regions import regions_for
+
+    entries = [
+        _entry(function="ping", access="public"),
+        _entry(function=None, access="local-only"),
+        _entry(function=None, access="public"),
+    ]
+    regions = regions_for(entries, [_target()])
+    assert len(regions) == 1
+    assert regions[0].function == "ping"
+
+
+def test_a_file_with_only_nameless_entry_points_still_gets_one_region() -> None:
+    from openultrasast.model.regions import regions_for
+
+    regions = regions_for([_entry(function=None), _entry(function=None)], [_target()])
+    assert len(regions) == 1 and regions[0].function is None
+
+
+def test_two_named_handlers_in_one_file_are_two_regions() -> None:
+    """Deduping must not collapse genuinely distinct handlers."""
+    from openultrasast.model.regions import regions_for
+
+    regions = regions_for([_entry(function="a"), _entry(function="b")], [_target()])
+    assert sorted(r.function for r in regions) == ["a", "b"]

tests/test_model_scan.py

@@ -145,3 +145,44 @@ def test_a_region_is_only_asked_about_families_it_carries() -> None:
 
     scan_repository(Path("/repo"), (_region(families=("injection",)),), backend=_B(), client=None, model="")
     assert "dominance" not in asked and "config" not in asked
+
+
+def test_the_driver_issues_one_query_invocation_per_kind_not_one_per_region(tmp_path) -> None:
+    """Task 1.4: JVM startup, not CPG construction, is what dominates a repository scan.
+
+    Before batching the driver issued one `joern --script` call per region per family. A ten-line Python file
+    admits six families, so it cost six JVM launches and over four minutes; a thousand regions would have
+    taken about fifty hours. The whole scan's questions now go in one invocation per query kind.
+    """
+    from openultrasast.model.scan import scan_repository
+
+    invocations: list[str] = []
+
+    class _CountingBackend:
+        def available(self):  # type: ignore[no-untyped-def]
+            return True
+
+        def build(self, root):  # type: ignore[no-untyped-def]
+            from openultrasast.cpg.backend import CpgResult
+
+            def run(query, params):  # type: ignore[no-untyped-def]
+                invocations.append(f"single:{query}")
+                return []
+
+            def run_batch(query, requests):  # type: ignore[no-untyped-def]
+                invocations.append(f"batch:{query}")
+                return {rid: [] for rid in requests}
+
+            result = CpgResult(cpg_path=Path("c.bin"), run=run)
+            object.__setattr__(result, "run_batch", run_batch)
+            return result
+
+    source = "import os\n\n\ndef run(cmd):\n    os.system(cmd)\n"
+    for i in range(30):
+        (tmp_path / f"f{i}.py").write_text(source)
+    regions = tuple(_region(path=f"f{i}.py", families=("injection", "path")) for i in range(30))
+
+    scan_repository(tmp_path, regions, backend=_CountingBackend(), client=None, model="")
+    assert not any(i.startswith("single:") for i in invocations), f"unbatched calls remain: {invocations[:4]}"
+    # 30 regions x 2 families would have been 60 invocations; batching makes it one per query kind.
+    assert len(invocations) <= 3, f"expected one invocation per query kind, got {len(invocations)}"