mirror of
https://github.com/norandom/OpenUltraSAST.git
synced 2026-10-16 03:49:26 +00:00
feat(model-grounded-detection): widen the settings table, wire the weak-algorithm arm
Two things, and a finding that says neither fixes the pairs that prompted them.
The settings table was Flask/FastAPI-shaped (CORS, set_cookie, app.run) while
the corpus contains aiohttp and Django applications, so three config_secrets
pairs contained no modelled security setting at all. Added aiohttp's
session_setup and cookie storages and Django's SECURE_* / DEBUG settings: 8
calls to 24.
And config_secrets spans three abstractions while only one was wired -- a
permissive setting VALUE. Weak algorithm CHOICE (CWE-326/327) is a different
thing: the danger is the algorithm NAMED, not a flag left open. Its data has
been sitting on the sink facts as `weak_literals` since before this feature and
nothing read it. Both abstractions read the same literal, so the arm is small:
hashlib.new("md5") is now entailed and hashlib.new("sha256") is not.
The finding: the three silent config pairs are CORPUS DEFECTS, not model gaps.
Measured similarity 23%, 45% and 53% -- dsvpwa-dsvpwa-main pairs `def main()`
against `def run(self, handler)`, a different function entirely. No settings
table can make those split, and it is worth saying so rather than letting the
work imply otherwise. The table gap was real and worth closing on its own
merits; it just is not why those pairs are silent.
734 passing, mypy/ruff clean, gates byte-identical.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01T7XD7x5KonMdmGRkp63EQG
This commit is contained in:
co-authored by
Claude Opus 5
parent
4e7fe65f17
commit
db3db6056d
@@ -76,3 +76,44 @@ def test_the_verdict_is_deterministic() -> None:
|
||||
"literalArgs": ["True", "0.0.0.0"], "args": ["x"]}]
|
||||
cpg = _cpg(rows)
|
||||
assert verdict(cpg, _spec(), function="login") == verdict(cpg, _spec(), function="login")
|
||||
|
||||
|
||||
# --- framework coverage and the weak-algorithm arm --------------------------------------------------------
|
||||
#
|
||||
# The settings table was Flask/FastAPI-shaped (CORS, set_cookie, app.run) while the corpus contains aiohttp
|
||||
# and Django. Separately, config_secrets spans three abstractions and only one was wired: a permissive
|
||||
# setting VALUE. Weak algorithm CHOICE (CWE-326/327) has its data already -- `weak_literals` on the hashlib
|
||||
# sink fact -- and nothing read it.
|
||||
|
||||
|
||||
def test_the_settings_table_covers_the_frameworks_in_the_corpus() -> None:
|
||||
from openultrasast.model.specs import config_specs
|
||||
|
||||
settings = set(config_specs(language="python")["config_secrets"].settings)
|
||||
for framework, call in (("aiohttp", "session_setup"), ("aiohttp", "EncryptedCookieStorage"),
|
||||
("django", "SECURE_SSL_REDIRECT"), ("flask", "set_cookie")):
|
||||
assert call in settings, f"{framework}'s {call} is not a modelled security setting"
|
||||
|
||||
|
||||
def test_a_weak_algorithm_is_entailed_by_its_literal() -> None:
|
||||
"""CWE-327: the danger is the algorithm NAMED, not a permissive flag."""
|
||||
from openultrasast.model.config_value import verdict
|
||||
from openultrasast.model.ladder import Rung
|
||||
from openultrasast.model.specs import config_specs
|
||||
|
||||
spec = config_specs(language="python")["config_secrets"]
|
||||
rows = [{"setting": 'hashlib.new("md5")', "line": "4", "method": "digest",
|
||||
"literalArgs": ['"md5"'], "args": ['"md5"']}]
|
||||
answer = verdict(_cpg(rows), spec, function="digest")
|
||||
assert answer is not None and answer.rung is Rung.ENTAILED
|
||||
assert "md5" in answer.witness.lower()
|
||||
|
||||
|
||||
def test_a_strong_algorithm_yields_no_finding() -> None:
|
||||
from openultrasast.model.config_value import verdict
|
||||
from openultrasast.model.specs import config_specs
|
||||
|
||||
spec = config_specs(language="python")["config_secrets"]
|
||||
rows = [{"setting": 'hashlib.new("sha256")', "line": "4", "method": "digest",
|
||||
"literalArgs": ['"sha256"'], "args": ['"sha256"']}]
|
||||
assert verdict(_cpg(rows), spec, function="digest") is None
|
||||
|
||||
Reference in New Issue
Block a user