Open_Ultra_SAST/.kiro/specs/access-control-prover/tasks.md

Implementation Plan

• 1. Paths from the caller index

• 1.1 Add PathRecord and compose_paths in src/openultrasast/semantic/obligations/paths.py (P)

  • Upward walk through a callers(path, function) callable, depth and fan-out bounds, stop at the first entry, chains kept per file, deduplicated; unreached targets returned
  • Done when tests/test_obligation_paths.py covers depth 1 to 3, unreached, fan-out cut and same-name files, and check_obligations accepts the records as paths (one test runs the checker with them)
  • Requirements: 3.1, 3.2, 3.3, 3.4, 3.5, 3.6
  • Boundary: obligations.paths

• 1.2 Checker opt-in assume_entries_protected and label unguarded_path in semantic/obligations/check.py

  • Default off; _finding receives the entry records' access by handler; evidence as the design states; findings_to_static explains the label; LABELS updated
  • Done when the existing checker tests pass unchanged and a new test shows: with paths, no policy, no siblings, the default gives no finding and the opt-in gives one unguarded_path finding for a non-public entry and none for an entry whose record access is public
  • Requirements: 4.1a
  • Boundary: obligations.check (opt-in only)

• 2. Entry recognisers

• 2.1 Stapler and Jetty recognisers in mapping.py (P)

  • Public do[A-Z]... methods on exposed types or with Stapler-typed or @QueryParameter parameters; Jetty AbstractHandler, HttpServlet, JAX-RS resources; evidence strings; public only for UnprotectedRootAction
  • Done when tests/test_mapping_frameworks.py names the entries of a fixture Descriptor, rejects a private helper named doX, and the existing mapping tests still pass
  • Requirements: 1.1, 1.6, 1.7, 1.8
  • Boundary: mapping

• 2.2 Symfony, Livewire and Laravel controller, Remix export and Tornado recognisers in mapping.py (P)

  • Done when fixture files of each shape yield route entries with evidence and the negative fixtures yield none
  • Requirements: 1.2, 1.3, 1.4, 1.5, 1.7, 1.8
  • Boundary: mapping

• 3. Enforcement witnesses and facts

• 3.1 semantic/obligations/enforcement.py producing router and decorator Discharge witnesses (P)

  • Laravel route middleware and controller middleware/authorizeResource; Symfony IsGranted, Security, security.yaml access_control; Tornado authenticated; names listed in the facts headers
  • Done when tests/test_obligation_enforcement.py shows a guarded Laravel route, a Symfony attribute and a Tornado decorator each produce one witness that OrderDominance accepts for the handler's operation
  • Requirements: 2.1, 2.2, 2.5, 2.6
  • Boundary: obligations.enforcement

• 3.2 Operation and discharger rows for the pool's shapes in ruleset/obligations/{java,php,python,typescript}.toml (P)

  • Java: credential lookups and outbound connection tests in doTestConnection-style handlers, item reads and writes, checkPermission/checkAnyPermission as path guards, hasPermission as ownership check; Remix: session requirements as path guards, record reads by request id as protected reads needing ownership_check; Tornado: handler open/get as entries needing path_guard; Jetty service start as privileged action. Every name checked in the clones or documentation, said in the header
  • Done when tests/test_obligation_facts.py loads the files and one operation and one discharger per language resolve
  • Requirements: 2.3, 2.4, 2.7
  • Boundary: ruleset/obligations

• 3.3 Handler-named operations: handlers and framework fields in the facts loader, find_operations(..., handlers_of=), Stapler form-validation rows in java.toml, Tornado handler rows in python.toml, Remix action rows in typescript.toml

  • Done when tests/test_obligation_facts.py loads a handler-named row, tests/test_obligation_operations.py (or the existing operations test file) yields the operation at the declaration line only for listed handlers, and the prover smoke on the 23 fixes reaches and checks the Jenkins form-validation methods
  • Requirements: 2.8
  • Boundary: obligations.facts, obligations.operations

• 4. The prover

• 4.1 hunt/prover.py: prove_change over the hunter Context, Coverage, findings as hunt defects

  • Touched functions from head lines, build output left out, targets include direct callees holding operations, IRs of hop files passed to the checker, extra witnesses from enforcement, coverage counts by reason, no model
  • Done when tests/test_hunt_prover.py shows: an unguarded Stapler handler calling lookupCredentials gives one finding with entry, hops and missing path_guard; a checkPermission above the call gives none; a guarded Laravel route gives none; an unrecognised framework gives coverage only; the finding dict has path, line, family, function, evidence, id
  • Requirements: 4.1, 4.2, 4.3, 4.4, 4.5, 4.6, 6.2, 7.1, 8.1, 8.2
  • Depends: 1.1, 2.1, 3.1, 3.2

• 4.2 semantic/obligations/trace.py: Guard, Hop, Trace, text() and record(); argument provenance through the IR's binds within each hop, forwarded along the path

  • Done when tests/test_obligation_trace.py serialises a three-hop fixture deterministically (text and JSON), traces an argument from an entry parameter to request_input, from a literal to constant, from an identity source to authenticated_context, and marks an unfollowable value unknown
  • Requirements: 9.1, 9.3, 9.4, 9.5
  • Boundary: obligations.trace

• 4.3 The prover emits a trace per examined pair (discharged and unguarded), the record and the defect carry them

  • Done when tests/test_hunt_prover.py shows a discharged pair and an unguarded pair each produce one trace with the verdict, the unguarded finding references its trace, and prover_arm records carry traces
  • Requirements: 9.1, 9.2, 9.5, 9.6
  • Depends: 4.2

• 4.4 semantic/cfg.py: structural control-flow graph per function from the syntax tree, dominators, control context (P)

  • Java, PHP, Python, JavaScript and TypeScript constructs of requirement 10.1; cfg_unavailable otherwise
  • Done when tests/test_semantic_cfg.py shows, per language, that a guard before an unconditional return dominates, a guard inside an if-branch does not dominate a statement after the branch, a guard inside a loop body does not dominate a statement after the loop, a try/catch is represented, and context reports conditions and loops
  • Requirements: 10.1, 10.2, 10.4
  • Boundary: semantic.cfg

• 4.5 obligations/cfg_dominance.py::CfgDominance, failure effects, and the trace's control components; the prover selects it; Java parameter names and handler-operation arguments cleaned

  • Done when tests/test_obligation_cfg_dominance.py shows a value-only predicate does not discharge while the same predicate guarding a throw does; a branch-only guard yields some_paths and no discharge; the prover smoke on the 23 fixes keeps or raises its recall; tests/test_mapping_frameworks.py shows Java parameter names without annotations
  • Requirements: 10.2, 10.3, 10.4, 10.5, 10.6, 10.7
  • Depends: 4.4

• 5. The arm

• 5.1 benchmarks/valid/prover_arm.py: run over a pool slice with checkpoints, summarise with the valid metrics

  • Record envelope copied from hunter_arm; instrument fields; resume; summary.json with recall (pushes and locations, Wilson), false alarms per 100, precision, instrument failures, seconds per change and the list over 120 s, per-repository and per-framework coverage, uncovered repositories; refuse on zero-byte reads
  • Done when tests/test_prover_arm.py runs a two-change fixture pool end to end and the summary carries every field above; a record with zero bytes read makes summarize refuse
  • Requirements: 5.1, 5.2, 5.3, 5.4, 5.5, 6.1, 7.2
  • Depends: 4.1

• 6. Measurement (maintainer, not Codex)

• 6.1 Run the arm on benchmarks/valid/train/pool-train.toml over the training clones; write benchmarks/measurements/<date>-access-control-prover/ with NOTES, summary, coverage table; compare with the DSPy and hunter arms of the same pool

  • Requirements: 5.2, 5.3, 7.2
  • Done 2026-10-28: benchmarks/measurements/2026-10-28-access-control-prover/ -- 23-repo pool (483 changes, 93 locations), recall 65.2% (Wilson 44.9-81.2), 15.0 FA/100, 0 instrument failures; on the 5 repos shared with the 2026-10-14 hunt arms, prover 4/5 vs DSPy 2/5 and hunter 2/5 (union 4/5), including trigger.dev which neither arm found.

• 7. Resolution foundation [2026-10-29]

• 7.1 CallSite receiver capture: receiver: str | None field on semantic/ir.py's CallSite, captured in semantic/cst.py call extraction (receiver expression text for $obj->method and x.y.z shapes; None for bare calls); every existing consumer unchanged

  • Done when IR fixtures show receiver text carried through call extraction for PHP/TS shapes, CallSite still constructs without it for existing callers, and all existing IR/cst tests pass unchanged
  • Requirements: 3.9
  • Boundary: semantic.ir, semantic.cst

• 7.2 (P) obligations.resolution: ClassRecord, class_table(texts, language) cached per change on the hunter Context, qualify(receiver, enclosing_class, name, arity, table) returning Class.name, Class.name/arity, or the bare name; base-class attachment rule (attaches to extending classes only)

  • Done when tests/test_obligation_resolution.py covers: two same-name methods on different classes give distinct keys; same name different arity gives distinct keys; an unresolvable receiver gives the bare name with receiver_unresolved counted; an abstract-base method attaches to a subclass call and not to an unrelated class
  • Requirements: 3.9
  • Boundary: obligations.resolution, hunt.producers (Context cache field only)

• 8. Guard binding and policy witnesses [2026-10-29]

• 8.1 (P) Resource-bound witnesses: optional resource field on Discharge (additive, default None); enforcement mints tokens (route path for router middleware, attribute/subject for a policy-layer guard, None for auth-class guards); policy-layer witness scoped to the action with the attribute or subject as resource (a policy decision -- voter, capability check, or equivalent -- reachable from the action or a function it calls). Which constructs count as policy decisions comes from the facts rows (task 10), never engine code

  • Done when tests/test_obligation_enforcement.py shows a resource-mismatch fixture (guard binds another object's resource, the operation stays undischarged under resource_bound) and a policy-witness fixture yielding a witness scoped to the action with the attribute as resource
  • Requirements: 2.10
  • Boundary: obligations.enforcement, obligations.operations (dataclass field only)

• 8.2 Checker opt-in resource_bound and all-kind caller-hop re-judgement in check.py's _on_caller_hop: a witness with resource set suppresses only operations whose resource token matches; every discharger kind is re-judged on earlier hops at the hop's call line; guards_before_call participates in the re-judgement

  • Done when the existing checker tests pass unchanged and new tests show: keyword off keeps today's behaviour (including the assume_entries_protected-gated hop re-judgement); keyword on, a mismatched-resource witness does not suppress; a guard one call deeper than the handler discharges; a guard dominating before a hop call yields no finding
  • Requirements: 2.10, 3.8, 3.10
  • Boundary: obligations.check (opt-in only)
  • Depends: 8.1

• 9. Recogniser registry [2026-10-29]

• 9.1 mapping/ package with a recogniser registry (Strategy pattern): registry table consulted by the language dispatch in mapping.py; the registration-sites strategy lands first -- call-site handler registration resolved through resolution.class_table, entries at the registered class's request-method declarations with registered_by evidence, registration-site vocabulary carried as fact data (task 10), not engine code; the recogniser returns unresolved registrations alongside the entries so the prover can count them

  • Done when tests/test_mapping_registration_sites.py shows a registration-site fixture (vocabulary from data rows) yielding entries at the registered class's file with registration evidence, an unresolved registration returned as such (no entry), mapping.py's dispatch consults the registry, and the existing mapping tests pass unchanged
  • Requirements: 1.9
  • Boundary: mapping
  • Depends: 7.2

• 9.2 Migrate the first legacy recogniser family (Stapler) from mapping.py's inline blocks into a mapping/ strategy module, proving the migration path; remaining families migrate per the breadth map, not this task

  • Done when Stapler entries come from mapping/stapler.py through the registry with the existing Stapler tests unchanged, and mapping.py contains no Stapler-specific regex
  • Requirements: 1.1
  • Boundary: mapping

• 10. Fact initialization job [2026-10-29]

• 10.1 (P) tools/fact_init.py: the one-time initialization pass per target. Extraction mode walks the legacy mapping.py blocks and current TOML rows and extracts embedded target vocabulary into the acquirable structures. Proposal mode takes an LLM or maintainer proposal for a target's vocabulary (entry shapes, registration sites, handler-name families, policy-decision constructs). The gate: every row passes the facts header discipline (source, version, region) and engine verification admits it (the row must match what the target's code says); only then promoted to a closed row

  • Done when tests/test_fact_init.py shows: extraction mode recovers the vocabulary of one legacy family into rows; a proposal matching a fixture repository is promoted; a proposal the fixture contradicts is rejected with the reason; nothing lands in the TOML files without passing the gate
  • Requirements: 2.7
  • Boundary: tools.fact_init, ruleset/obligations (rows it produces)

• 10.2 First initialization run for the training pool's target families: produce the handler-name rows for webhook/build-trigger and data-exposure shapes, the registration-site vocabulary, and the policy-decision constructs, as data rows admitted through the gate (names verified against the pool clones; header updated)

  • Done when the pool's gate-1 miss shapes (Stapler webhook/data-exposure handlers, programmatic registration, policy voters) are all carried as rows with headers, no engine module names a target, and tests/test_obligation_facts.py loads each family
  • Requirements: 2.7, 2.9, 2.10, 1.9
  • Boundary: ruleset/obligations
  • Depends: 10.1, 9.1, 8.1

• 11. Prover resolution integration [2026-10-29]

• 11.1 Target enumeration joins callees by qualified key with a down_depth budget (default 2, sharing the fan-out bound) so operations one call deeper are reached; the callers adapter keeps only callers whose receiver binds to the target's class or subclass; unresolvable receivers fall back to the bare name and are counted receiver_unresolved; unresolved registrations from mapping are counted registration_unresolved in Coverage

  • Done when tests/test_hunt_prover.py shows: an operation one call deeper than the handler is reached and checked; a same-name method on another class yields a separate verdict (no cross-contamination); coverage carries receiver_unresolved when a receiver does not resolve and registration_unresolved when a registration target is outside the repository
  • Requirements: 3.7, 3.9
  • Boundary: hunt.prover
  • Depends: 7.1, 7.2, 9.1

• 12. Arm and coverage [2026-10-29]

• 12.1 (P) Recognition or resolution exceptions inside prove_change are recorded under error:<exception class name> reason keys in coverage, never folded into framework_unrecognised or any other quiet reason

  • Done when a fixture raising inside a recognition or resolution pass counts under error:<class> and framework_unrecognised stays empty for that fixture
  • Requirements: 7.3
  • Boundary: hunt.prover

• 12.2 (P) Stale-anchor refusal in prover_arm._prove: every returned finding's path is validated against the files actually read; an absent path marks the record instrument_failure with reason stale_anchor and findings cleared; summarize refuses such runs listing the record ids

  • Done when tests/test_prover_arm.py shows a fixture finding on an absent path makes _prove mark the record and makes summarize refuse, mirroring the zero-byte refusal
  • Requirements: 5.6
  • Boundary: prover_arm

• 13. Measurement after the amendment (maintainer, not Codex) [2026-10-29]

• 13.1 Re-run the arm on benchmarks/valid/train/pool-train.toml after tasks 7-12 land; write benchmarks/measurements/<date>-access-control-prover-v2/ with NOTES, summary, coverage table; compare against the 2026-10-28 gate 1 run (recall 65.2%, FA 15.0/100) on the same pool

  • Requirements: 5.2, 5.3, 7.2

Task constraints [2026-10-29]

From .kiro/steering/code-standards.md, binding on every task above:

• Complexity caps: McCabe <= 10 per function; <= 50 LLOC per function; <= 400 LLOC per new module. A task is not done while a function it touched exceeds a cap; split the function.
• Pattern discipline: tasks 9.1-9.2 implement Strategy + Registry; task 10.1 implements the acquisition pipeline behind the Interpreter discipline (rows are the language); task 11.1 is the Adapter at the engine seam. New recognisers land in mapping/ strategy modules, never as mapping.py blocks.
• Idiomatic naming: names state what a value semantically is in the pipeline vocabulary; collections name their elements (entry_point_records, judgments_by_key); booleans are predicates; no abbreviations like eps, recs, d2.

Implementation Notes

• Delivery A (2026-10-14) implements paths, the opt-in checker premise, Stapler/Jetty/Servlet/JAX-RS entries, the Java facts, the deterministic prover and the checkpointed arm. No commit was made.

• Task 3.2 stays open for the PHP, Python and TypeScript facts. Task 4.1's delivery A core is delivered; its full-spec checkbox stays open for delivery B's enforcement witnesses and guarded Laravel acceptance case. This delivery intentionally passes extra_witnesses=() as required by the maintainer's brief.

• Default checker behavior is preserved. Only opt-in checking includes a caller's statement witness, using the existing dominance contract at the outgoing call site. The prover checks each complete path independently so a guarded chain cannot hide an unguarded chain to the same operation.

• Java additions were checked against actual Git HEAD source objects in the sparse training clones; checked call sites are named in the Java TOML header. No network or model call was made.

• Mapping accepts cached source texts and an opt-out from external manifest scanning. Default callers retain their previous behavior; the delivery A prover uses source entries and its Context caches.

• Delivery A review was performed in the main context because the brief forbids model calls. The exact requested static gate passed (format, Ruff and mypy); the exact pytest gate passed with 112 passed, zero failed, exit 0. UV_NO_SYNC=1 was set; UV_CACHE_DIR was placed under /tmp because the default cache is outside the writable sandbox. The unchanged unjustified-path checker test remains intact.

• Delivery B (2026-10-14) implements task 2.2's Symfony, Livewire/Laravel, Remix and Tornado entries, task 3.1's scoped enforcement witnesses, task 3.3's handler facts and operation discovery, and task 4.1's integration. Changes remain uncommitted as the brief requires.

• Handler facts are explicitly opt-in through file-qualified handler maps in the checker. The prover uses handler obligations where a Stapler or Tornado entry reaches no listed call operation; existing call-site findings and Delivery A tests remain unchanged. Remix retains its handler operation even when listed calls exist, and independently requires a path guard and an ownership check. Public access waives only the path guard for these handler facts. The checker default is unchanged.

• The prover supplies a local dominance adapter for handler facts: it checks guards within the handler body while reporting the operation at its declaration. A final ordinary return does not turn a bare permission predicate into a guard. OrderDominance and the existing producers and arms are unchanged.

• Remix arrow exports are named locally in the prover's IR copy, including TSX route modules. Symfony recognises positional and named route paths and class prefixes. Tornado recognises local subclasses and the pool terminal's terminado base when it explicitly invokes Tornado's WebSocketHandler method.

• PHP CST Point.row access crashed on the larger Kimai controller with the installed native parser. New recognisers derive line numbers from byte offsets instead; a fixture past line 320 and the 23-change source smoke complete without a crash. Existing CST code was not modified.

• Task 3.2 remains partially complete: TypeScript adds clone-verified requireUserId and authenticateApiRequest, retaining requireUser and authorize; PHP rows are retained and their header records enforcement sources. Python retains the existing authenticated decorator and gains the Tornado handler operation. No get_current_user fact was added: Git searches of Mage HEAD, the pool revision and websocket fix 66440e4d3 found neither that API nor an authenticated decorator use, and local framework documentation was unavailable. The brief forbids network access and unsourced names.

• Review used the main-context fallback because the brief prohibits model calls. Verdict: APPROVED for tasks 2.2, 3.1, 3.3 and 4.1; task 3.2 remains open for its source-verification gap. No new placeholder markers, credentials, dependencies, producer edits or arm edits were introduced.

• Fresh verification: UV_NO_SYNC=1 and UV_CACHE_DIR=/tmp/ousast-uv. The exact static gate passed: ruff format --check ., ruff check ., mypy src/openultrasast (178 source files). The exact requested pytest gate plus test_obligation_operations.py passed with 145 passed, zero failed, exit 0. Initial missing-feature tests produced 24 failed and 14 passed; integration tests initially produced eight failed and 20 passed. No test_search_* test was run.

• A separate file-scoped smoke read immutable Git source objects for all 23 access-control changes, validated their commit objects and source digests, and recorded nonzero input bytes for every change. All 23 executions completed, zero errors; 16 changes checked operations and seven remained unchecked. It materialised only changed source files in temporary directories, so it is not a full-repository recall measurement. The maintainer-owned task 6.1 and release readiness remain unclaimed.

• Delivery C (2026-10-14) implements tasks 4.2 and 4.3: ordered traces for every examined path/operation pair, argument origins through local bindings and forwarded parameters, traces in prover results and arm records, and trace references on unguarded findings. Existing checker decisions and coverage accounting are unchanged. Declared route access is retained in the trace.

• Delivery C review used the main context because the brief prohibits model calls. Verdict: APPROVED for tasks 4.2 and 4.3. Regression cases cover unresolved collections, overwritten bindings, source-name boundaries, missing IR arguments, method parameter forwarding and return-order guards.

• Fresh delivery C verification with UV_NO_SYNC=1 and UV_CACHE_DIR=/tmp/ousast-uv: the exact requested static gate passed (format, Ruff, mypy over 179 source files); the exact pytest gate passed with 102 passed, zero failed, exit 0. The initial trace test failed collection because trace.py did not yet exist; additional regression tests failed before their fixes. No test_search_* test, network request or model call was made. Changes remain uncommitted.