Files
Open_Ultra_SAST/benchmarks/push/family_census.py
T
Marius CiepluchandClaude Opus 5 c93669c34f fix(scan): a language boundary is a declared limit, not a graph-integrity failure
Membership of GRAPH_INTEGRITY_GAPS should turn on whether a gap can make a reported answer WRONG,
not on whether it cost coverage. An unparsed file may hold the sanitizer that would have cleared a
flow this scan reports, so it belongs there. A flow this tool cannot follow from one language into
another can hide a finding and never invent one, because a PHP sink is sanitised in PHP.

cross_partition_semantics_unresolved therefore moves to DECLARED_EXCLUSION_GAPS. It touches exactly
two places, both of which already honour the distinction: the outcome demotion in scan.py, and
_blocking_degradations in the push policy, whose docstring already says a declared exclusion is not
one of them. The reason stays published in the scope unresolved boundaries either way, so the limit
is still reported; the class decides only whether every answer in the repository is demoted.

This corrects the task note written earlier today, which said not to reclassify on the grounds that
it would claim cross-language flows are out of scope rather than unresolved. That was a misreading
of the class.

PMPro still completes none of its questions, and the measurement now names why: the JavaScript
partition expected 36 files and holds 32, so partition_file_census_incomplete fires and is still an
integrity gap. The four absent files are js/blocks/blocks.build.js, js/jsapi.js, js/select2.min.js
and webpack.config.js -- a build output, a source file, a minified third-party library and a build
config. A bundled select2 costs 4,425 PHP regions their admissibility. Same over-broad blast
radius, third instance of one principle in this thread, and the fix direction is recorded.

The census harness now records each degradation whole rather than only its reason, because a
partition census that reports files missing carries WHICH files and without them the gap is a label
rather than a lead.

1,417 tests pass, eighteen skipped.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01EmM1j46qgKMh3zqD1QMwEo
2026-09-21 12:04:28 +02:00

156 lines
7.5 KiB
Python

"""Which declared vulnerability families actually establish findings on real code?
Seven families are declared. Two are proven end to end: injection on NodeGoat and VAmPI, and access
control on VAmPI once its change context could complete. The other five have never been checked for
whether they produce a witness on anything, and a family that is declared but silent is advertised
coverage the tool does not have.
This runs the production discovery and scan over a whole checkout and reports, per family, how many
regions were asked, how many questions completed, and what was found with the witness and rung that
established it. It makes no novelty or admission claim: there is no comparison here, only detection.
A family reporting nothing is recorded as nothing. That is the point of asking.
"""
from __future__ import annotations
import argparse
import collections
import json
import time
from pathlib import Path
from typing import Any
from openultrasast.cpg.backend import JoernBackend
from openultrasast.mapping import analyze_entry_points, php_hook_callbacks
from openultrasast.model.contracts import ExecutionBudget
from openultrasast.model.regions import regions_for
from openultrasast.model.scan import ScanBudget, scan_repository
from openultrasast.model.shipped import declared_sources
from openultrasast.preprocess import build_file_target, enumerate_source_files
def main() -> int:
parser = argparse.ArgumentParser(description=__doc__)
parser.add_argument("--out", type=Path, required=True)
parser.add_argument("--root", type=Path, required=True)
parser.add_argument("--name", required=True)
parser.add_argument("--deadline", type=float, default=1800.0)
parser.add_argument("--max-regions", type=int, default=500)
args = parser.parse_args()
args.out.mkdir(parents=True, exist_ok=True)
record: dict[str, Any] = {
"schema_version": 1,
"experiment": "family-detection-census-v1",
"subject": args.name,
"root": str(args.root),
"claim_scope": "Detection only. No comparison, no novelty, no admission, no capability enabled.",
}
target = args.out / f"{args.name}.json"
def save() -> None:
target.write_text(json.dumps(record, indent=2, default=str) + "\n")
files = enumerate_source_files(args.root)
targets = [build_file_target(args.root, path) for path in files]
opened = sum(path.stat().st_size for path in files if path.is_file())
regions = regions_for(analyze_entry_points(args.root, targets), targets, shipped=declared_sources(args.root))
record["inputs"] = {"files": len(files), "bytes": opened, "regions": len(regions)}
record["regions_by_family"] = dict(collections.Counter(f for r in regions for f in r.families))
record["languages"] = dict(collections.Counter(r.language for r in regions))
save()
if not files or not opened:
record["error"] = "no readable source"
save()
return 2
backend = JoernBackend(execution_budget=ExecutionBudget(time.monotonic() + args.deadline, 5.0))
hooks = php_hook_callbacks(args.root, targets) if any(r.language == "php" for r in regions) else {}
started = time.monotonic()
result = scan_repository(
args.root,
regions[: args.max_regions],
backend=backend,
budget=ScanBudget(max_model_calls=0, max_regions=args.max_regions, order_by_evidence=True),
execution_budget=ExecutionBudget(time.monotonic() + args.deadline, 5.0),
ranking_mode="evidence",
unit="repository",
population_complete=True,
)
record["scan"] = {
"seconds": round(time.monotonic() - started, 1),
"build_seconds": result.build_seconds,
"query_seconds": result.query_seconds,
"hook_table_hooks": len(hooks),
"degradations": [str(d.get("reason")) for d in result.degradations],
# The reason alone cannot be acted on. A partition census that reports files missing carries WHICH
# files, and without them the gap is a label rather than a lead.
"degradation_detail": [
{k: (v[:20] if isinstance(v, list) else v) for k, v in d.items() if k != "stage"} for d in result.degradations
],
"questions_total": len(result.question_outcomes),
"questions_completed": sum(1 for q in result.question_outcomes if q.status == "completed"),
"findings_total": len(result.findings),
# Why the outcomes say what they say, counted rather than inferred: a family can find something while
# every one of its questions is recorded unresolved, and the two numbers then disagree in public.
"outcome_status": dict(collections.Counter(q.status for q in result.question_outcomes)),
}
asked = collections.Counter(q.identity.family for q in result.question_outcomes)
completed = collections.Counter(q.identity.family for q in result.question_outcomes if q.status == "completed")
found: dict[str, list[dict[str, Any]]] = collections.defaultdict(list)
for finding in result.findings:
found[finding.family].append(
{
"site": finding.site,
"rung": finding.rung.value,
"witness": (finding.witness or "")[:200],
"reached_from": finding.reached_from,
}
)
# Families with regions but no question must appear, or the census hides its own biggest finding: on
# VAmPI four declared families were offered 25 regions each and asked nothing, and building this list
# from the questions alone made them invisible rather than negative.
offered = record["regions_by_family"]
families = sorted(set(offered) | set(asked) | set(found))
record["families"] = {
family: {
"regions_offering": offered.get(family, 0),
"questions_asked": asked.get(family, 0),
"questions_completed": completed.get(family, 0),
"findings": len(found.get(family, [])),
"rungs": dict(collections.Counter(item["rung"] for item in found.get(family, []))),
"examples": found.get(family, [])[:10],
# The distinction that matters: a family that answered and found nothing is a different
# statement from one that could not answer, and neither is "clean".
#
# Findings are checked FIRST, and that order is the whole point. It used to ask about completion
# before findings, so a family that established 18 findings on a PHP plugin while no question
# outcome was marked completed reported "asked but no question completed" -- and a census whose
# job is to say what each family finds reported nothing for a repository that had found a real
# SQL injection. A question-outcome count is a statement about bookkeeping; a finding is the
# thing being censused, and it cannot be hidden behind the other.
"verdict": (
"establishes findings"
if found.get(family)
else "region offered, no question asked"
if not asked.get(family)
else "asked but no question completed"
if not completed.get(family)
else "answered, nothing found"
),
}
for family in families
}
record["summary"] = dict(collections.Counter(entry["verdict"] for entry in record["families"].values()))
save()
cleanup = getattr(result, "cleanup", None)
if callable(cleanup):
cleanup()
print(json.dumps({"subject": args.name, "summary": record["summary"]}), flush=True)
return 0
if __name__ == "__main__":
raise SystemExit(main())