Marius CiepluchandClaude Opus 5
3224884d8f
Add group 9 to the approved task plan as the bounded owner amendment release milestone M1a requires, implement the task-local recorded-veto evaluation flag, and run the three pinned NodeGoat revisions under it. The flag re-runs the production comparison and admission over a lifted copy of the same evidence and records each veto instead of applying it. Recognized completeness vetoes are lifted and logged; failures never are, because silence from a failure is not a quiet fixed twin. It is off by default, accepted only on explicit base/head replay, refused in Git stdin mode, labels every payload it produces, and admits no defect even when a lifted candidate otherwise would. M1a outcome, inside its one-week box and with expectations frozen on disk first: the three entailed <lambda>2 witnesses are present at contributions.js 32-34; the fixed twin was genuinely analyzed and quiet, answering its target question with zero rows and no deadline reason while the same findings appear as base-only; the unchanged revision was analyzed and recorded unchanged. The kill criterion did not trigger. Five vetoes fired and were recorded. M1a also corrected the diagnosis: with all five lifted the detection still stops at operation_correspondence_unresolved, because a newly introduced operation sits on a changed line and has no base anchor. The unchanged revision resolves its base location on the same lines and classifies as unchanged, which isolates correspondence as the mechanism. That fifth veto was not in the earlier four-veto diagnosis and is now M1b's central repair. Diagnosis only. No defect admitted, no capability enabled, no gate changed, no latency claim; the 900-second development budget cannot measure the hook gate. Rollout and task 8.3 remain NO-GO. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01EmM1j46qgKMh3zqD1QMwEo
6.0 KiB
Pre-push safety net status — v1.2.0-alpha.1
Updated 2026-09-16. Phase: implementation. Requirements, design and tasks are approved. 28/29 executable tasks complete; task 8.3 remains blocked. Rollout: NO-GO. The alpha tag publishes experimental implementation and evidence; it does not approve normal hook capabilities or production enforcement.
Next release milestone
M1a is met. M1b is next: repair only the vetoes M1a showed to matter, then rerun the three revisions through the production rules. The other four milestones remain unverified.
M1a ran on 2026-09-16 within its one-week box. The raw <lambda>2 witnesses are present at
contributions.js lines 32–34, the fixed twin was genuinely analyzed and quiet, and the
unchanged revision was not reported as a new regression, so the kill criterion did not
trigger. Five vetoes fired and were recorded; with all five lifted the detection still stops
at operation_correspondence_unresolved, because a newly introduced operation sits on a
changed line and has no base anchor. That fifth veto was not in the earlier diagnosis and is
now M1b's central repair. See M1a evidence.
The 28/29 task count is implementation progress, not proximity to rollout. Follow the accepted release milestone spec: usefulness → speed → shared PHP/Python transfer → independent qualification → narrow advisory rollout.
Verified
Immutable pushed snapshots, shared multi-ref deadlines, ranker-owned scope, physical vendor exclusion, compatible immutable graph/result reuse, actionability admission, compact truthful reporting and non-destructive hook integration are implemented. Advisory and blocking share the same evidence bar; optional model output cannot bypass it.
Contributor-scan task 2.19 is verified: the pinned frontend now retains the original Gruntfile, bringing the real NodeGoat census from 43/44 to 44/44 files. Partial, absent and malformed census no longer masquerade as a complete result or a falsely empty graph. The final code verification recorded 1321 passed tests, nine skipped, passing canonical gates and a packaged native PHP/JavaScript partition smoke. See owner verification.
Rollout blockers
- Useful checks within the deadline are unproven. The fresh post-census profile completed all 21 measurements: all 18 changed/cold/growth/multi-ref transactions timed out; the three identical-tip replays took 18.521–18.874s with valid graph/query reuse. Still 0/24 declared target checks completed. Maximum observed cancellation/report overrun was 0.874s, below the two-second allowance. After M1 establishes the useful comparison, amortize engine startup/loading and rerun the frozen seven-class profile; require warm p95 <=30s and >=95% completed supported checks.
- Target and change-context evidence remains incomplete. M1a measured exactly which contracts fail on the Node case: per-family change context, question-owned vendor relevance, operation correspondence for changed lines, file-wide correspondence ambiguity and query-to-operation provenance. VAmPI preserves raw findings at all three known sites, but the exact SQLI function question/transitive witness and supported authorization context are unresolved. Raw findings or rank positions cannot establish an actionable new regression. Repair this in the shared scan boundary and verify the actual associated query/path evidence.
- Independent quality qualification is missing. Freeze and review untouched Node API vulnerable/fixed/benign cases, including middleware/module/async context. Ghost remains reserved with missing reviewed inputs. PHP and Python need their own independent language/framework/family populations; Node results cannot qualify them. Require >=95% observed actionable precision with counts/intervals, >=90% supported recall, nonzero reviewed emitted alerts/positive controls and zero known fixed/benign false alerts.
- No current capability is eligible. The earlier registry is NO-GO and becomes stale under the repaired runtime/core identities. Loading it enables zero capabilities. After the preceding evidence passes together, regenerate exact-semantic eligibility and rerun packaged acceptance validation. Do not relabel old measurements as current.
C/libpng arithmetic and bounds remain explicitly unsupported; this is not a C/C++ detection qualification. Advisory rollout cannot be justified by silence from an unqualified registry.
Ownership and revalidation
Engine lifecycle, source/census and context/witness normalization belong to
contributor-scan. The hook consumes those contracts; no second engine, source IR,
ranker priority exceptions or differential graph mutation is introduced here. Graph
mutation would need a separate cold-equivalence experiment.
After owner fixes, refreeze identities and rerun ordinary scan gates, Python regressions, PHP-to-Node transfer, the representative cache/deadline profile, independent per-capability quality evaluation and packaged hook validation. Keep task 8.3 unchecked and the feature in implementation until those mandatory results are established.
Evidence: group 8 validation, post-census runtime scorecard, census repair.
The owner investigation now distinguishes missing family context producers, globally propagated vendor/correspondence gaps, and query-to-operation identity. See remediation research. These are next implementation prerequisites, not completed fixes or changed acceptance gates.
An isolated Joern session probe matched the full Node census with four warm requests in 0.221–0.467s and verified cancellation/reaping in 0.043s. It identifies a promising engine lifecycle change; full-query equivalence and changed-code performance remain unverified.