mirror of
https://github.com/norandom/OpenUltraSAST.git
synced 2026-10-18 12:39:28 +00:00
Marius CiepluchandClaude Opus 5
c2d9c4ad01
Eight of the ten vendored access-control rows had no named handler at all, so every one of them would have scored `missing_context` forever rather than as a detector miss. After the re-harvest nine are named and the tenth states its reason. The handler-context mode now carries the class its framework registers, multi-line decorators, and commented-out guards -- `#@token_required` above a ThreatByte handler is the entire bug. Where the registration lives in another document (connexion's `operationId`, an express router), a recipe names `context = [...]`, the harvester writes that stanza per side, and the pair materializes both files at their repository-relative paths so the entry-point mapper sees the layout the project has. `harvest_recipe` fetches every blob before the first write and the driver takes `--report`, so a failed fetch leaves a reviewed excerpt exactly as it was. Two defects the re-harvest exposed: `.mjs` was not a known suffix, so the one pair vendored as an ES module had no file target at all; and `_python_route_access` matched auth words inside decorator prose, reading `@ns.doc(description='... without proper authorization checks')` as a guard. Recorded in the hygiene artifact: nine of the ten duplicate groups sit on both sides of the split, which the repository-level split cannot see. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01T7XD7x5KonMdmGRkp63EQG
42 lines
1.8 KiB
Python
42 lines
1.8 KiB
Python
# Provenance: erev0s/VAmPI get_by_title (fixed).
|
|
# repo: erev0s/VAmPI
|
|
# commit: 1713b54b601ad29582581eeda4b31fceb1319874
|
|
# parent: 1713b54b601ad29582581eeda4b31fceb1319874
|
|
# commit_url: https://github.com/erev0s/VAmPI/blob/1713b54b601ad29582581eeda4b31fceb1319874/api_views/books.py#L51
|
|
# cve:
|
|
# license: MIT
|
|
# function: get_by_title
|
|
# relpath: api_views/books.py
|
|
# provenance: human
|
|
# mechanism: missing_auth_guard
|
|
# upstream_start: 45
|
|
|
|
def get_by_title(book_title):
|
|
resp = token_validator(request.headers.get('Authorization'))
|
|
if "error" in resp:
|
|
return Response(error_message_helper(resp), 401, mimetype="application/json")
|
|
else:
|
|
if vuln: # Broken Object Level Authorization
|
|
book = Book.query.filter_by(book_title=str(book_title)).first()
|
|
if book:
|
|
responseObject = {
|
|
'book_title': book.book_title,
|
|
'secret': book.secret_content,
|
|
'owner': book.user.username
|
|
}
|
|
return Response(json.dumps(responseObject), 200, mimetype="application/json")
|
|
else:
|
|
return Response(error_message_helper("Book not found!"), 404, mimetype="application/json")
|
|
else:
|
|
user = User.query.filter_by(username=resp['sub']).first()
|
|
book = Book.query.filter_by(user=user, book_title=str(book_title)).first()
|
|
if book:
|
|
responseObject = {
|
|
'book_title': book.book_title,
|
|
'secret': book.secret_content,
|
|
'owner': book.user.username
|
|
}
|
|
return Response(json.dumps(responseObject), 200, mimetype="application/json")
|
|
else:
|
|
return Response(error_message_helper("Book not found!"), 404, mimetype="application/json")
|