Files
Marius CiepluchandClaude Fable 5.1 17194b3df9 ci: pytest runs with the hunt and semantic extras kept; sandbox tests skip by cause where no bwrap exists
CI's first full pytest run since 2836b78 showed 65 failures in three classes. uv run re-synced the environment
to the lockfile's default extras before pytest, removing dspy again (UV_NO_SYNC=1 now). The learn slice, pair
corpus and hunt producer tests need tree-sitter (semantic extra installed). Thirty-two tests need bubblewrap
isolation, which CI's container cannot provide: they carry a sandbox marker and skip where the isolation
preflight fails, with the cause's type in the reason; proven locally by hiding bwrap (7 skipped, 23 passed).
The partial-clone extraction test now probes one lazy fetch through git itself first, so git's own stderr
reaches the next CI log instead of git_exit_128.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
2026-10-14 07:54:09 +02:00

150 lines
6.7 KiB
Python

"""Shared test fixtures."""
import subprocess
import sys
import pytest
@pytest.fixture(autouse=True)
def _pointer_pairs_offline(monkeypatch: pytest.MonkeyPatch, tmp_path_factory: pytest.TempPathFactory) -> None:
"""Req 10.4: the default test run never touches the network for pointer pairs, whatever the operator's shell exports."""
monkeypatch.delenv("OPENULTRASAST_PAIRS_NETWORK", raising=False)
monkeypatch.setenv("OPENULTRASAST_PAIR_CACHE", str(tmp_path_factory.mktemp("pair-cache")))
@pytest.fixture(autouse=True)
def _repos_offline(monkeypatch: pytest.MonkeyPatch, tmp_path_factory: pytest.TempPathFactory) -> None:
"""Req 4.1: pinned repository recipes never fetch during a test run, whatever the operator's shell exports.
The cache is redirected as well as the switch cleared, so a developer with warm checkouts and a test that
forgets to pass an explicit root still cannot read them by accident.
"""
monkeypatch.delenv("OPENULTRASAST_REPOS_NETWORK", raising=False)
monkeypatch.setenv("OPENULTRASAST_REPO_CACHE", str(tmp_path_factory.mktemp("repo-cache")))
@pytest.fixture
def assert_cold_import(): # type: ignore[no-untyped-def]
"""Run ``code`` in a fresh interpreter and assert it exits 0.
Hermetic by construction: an import-laziness check (``code`` asserts on ``sys.modules`` itself) is not
polluted by modules other tests have already imported into this process.
"""
def _check(code: str) -> str:
proc = subprocess.run(
[sys.executable, "-c", code],
capture_output=True,
text=True,
)
assert proc.returncode == 0, f"exit={proc.returncode}\nstdout={proc.stdout}\nstderr={proc.stderr}"
return proc.stdout
return _check
@pytest.fixture(autouse=True)
def _scratch_under_tmp_path(monkeypatch: pytest.MonkeyPatch, tmp_path_factory: pytest.TempPathFactory) -> None:
"""Every CPG build makes an `ousast-cpg-*` scratch directory, and a test that feeds it a fake engine never
reaches the cleanup a real run does: one run of the backend tests left fifteen of them in the system
temp directory, and the product's stale sweep waits six hours. Pointing `tempfile` at the test's own
directory keeps them out of `/tmp` entirely, whatever the test forgets.
"""
import tempfile
scratch = tmp_path_factory.mktemp("scratch")
monkeypatch.setattr(tempfile, "tempdir", str(scratch))
FAKE_KUBECTL_ATE = r'''#!{python}
"""Fake kubectl-ate for egress policies: an actor exists while ``applied/<actor>.json`` exists and is not gone
(the fake ax's record); its policy goes with it, as Substrate's store cascades. Every call is logged to ax.log."""
import json, sys, time
from pathlib import Path
HERE = Path(__file__).resolve().parent
argv = sys.argv[1:]
context = ""
if argv[:1] == ["--context"]:
context, argv = argv[1], argv[2:]
verb, actor, space = argv[0], argv[2], argv[argv.index("-a") + 1]
with (HERE / "ax.log").open("a") as log:
log.write(f"{time.monotonic():.4f} egress {verb} {actor} {context}\n")
record = HERE / "applied" / f"{actor}.json"
alive = record.exists() and not json.loads(record.read_text()).get("gone")
store = HERE / "policies" / f"{space}_{actor}.json"
if not alive:
store.unlink(missing_ok=True)
sys.exit(print(f'Error: actor "{actor}" in atespace "{space}" not found', file=sys.stderr) or 1)
if verb == "get":
if not store.exists(): # kubectl-ate: no policy is a valid state, exit 0 with nothing on stdout
sys.exit(print(f'actor "{actor}" in atespace "{space}" has no egress policy', file=sys.stderr) or 0)
print(store.read_text())
elif verb in ("create", "update"):
body = json.loads(sys.stdin.read())
old = json.loads(store.read_text()) if store.exists() else None
if verb == "create" and old is not None:
sys.exit(print("Error: already exists", file=sys.stderr) or 1)
version = 1 if old is None else old["metadata"]["version"] + 1
body["metadata"] = {"name": "default", "atespace": space, "uid": "uid-1", "version": version}
store.parent.mkdir(exist_ok=True)
store.write_text(json.dumps(body))
(HERE / "policies" / f"{space}_{actor}.written.json").write_text(json.dumps(body)) # survives the cascade
print(f"egress policy {verb}d")
'''
@pytest.fixture
def kubectl_ate(tmp_path, monkeypatch: pytest.MonkeyPatch):
"""A fake ``kubectl-ate`` in ``tmp_path`` (shared with the fake ax there); no settle wait."""
path = tmp_path / "kubectl-ate"
path.write_text(FAKE_KUBECTL_ATE.replace("{python}", sys.executable), encoding="utf-8")
path.chmod(0o755)
monkeypatch.setenv("OUSAST_KUBECTL_ATE", str(path))
monkeypatch.setenv("OUSAST_EGRESS_SETTLE", "0")
return path
PROFILE_CONTEXT = "kind-test" # the fakes must receive this, never a context a module built (plane-on-kubernetes 1.2)
PROFILE_TOML = (
'exec = "local"\nkube_context = "{context}"\nregistry = "registry.test:5000"\nimages = "images.json"\n'
'memory = "file://{memory}"\natespace = "default"\n[pools.default]\nreplicas = 1\ncpu = "1"\nmemory = "1Gi"\n'
)
@pytest.fixture
def plane_profile(tmp_path, monkeypatch: pytest.MonkeyPatch):
"""A throwaway PlaneProfile under ``tmp_path`` (context ``kind-test``, a file:// memory store, a digest-pinned
images file), selected through ``OUSAST_PLANE_PROFILE`` so every plane module loads it."""
import json
root = tmp_path / "profile"
root.mkdir()
(root / "test.toml").write_text(PROFILE_TOML.format(context=PROFILE_CONTEXT, memory=tmp_path / "memory"), encoding="utf-8")
(root / "images.json").write_text(json.dumps({"runner": "registry.test:5000/ousast-runner@sha256:" + "ab" * 32}), encoding="utf-8")
monkeypatch.setenv("OUSAST_PLANE_PROFILE", str(root / "test.toml"))
for key in ("OUSAST_KUBE_CONTEXT", "OUSAST_MEMORY", "OUSAST_REGISTRY", "OUSAST_IMAGES", "OUSAST_EXEC"):
monkeypatch.delenv(key, raising=False)
return root / "test.toml"
def pytest_collection_modifyitems(config: pytest.Config, items: list[pytest.Item]) -> None:
"""Tests marked ``sandbox`` need bubblewrap isolation; where the preflight fails they skip, named by cause.
CI's container has no bwrap and no user namespaces, so these tests can only run on a host; a skip there is
an honest statement, a failure there says nothing about the code."""
marked = [item for item in items if item.get_closest_marker("sandbox")]
if not marked:
return
from openultrasast.search import _sandbox
try:
_sandbox.isolation_check(timeout_seconds=30)
except _sandbox.IsolationUnavailable as exc:
reason = f"sandbox isolation unavailable ({type(exc.__cause__ or exc).__name__})"
else:
return
for item in marked:
item.add_marker(pytest.mark.skip(reason=reason))