mirror of
https://github.com/norandom/OpenUltraSAST.git
synced 2026-10-16 03:49:26 +00:00
Marius CiepluchandClaude Opus 4.8
39a1873e5b
Ran the humanizer rules over 79 prose files in the active specs (brief, design, requirements, research and narrative docs). Removed em dashes, significance inflation, forced rule-of-three, bold-label list items and filler. Skipped tasks.md checklists and the retired specs (harnessx-*, openrouter-sast-harness, unseen-repo-evaluation). Every number, path, command, hash and identifier was preserved: checked each file against HEAD for drift in numbers, inline code and code fences, zero drift across all 79 files. Co-Authored-By: Claude Opus 4.8 <[email protected]>
96 lines
6.2 KiB
Markdown
96 lines
6.2 KiB
Markdown
# Brief: ir-consolidation, stop maintaining an IR we did not need, and adopt one we do
|
|
|
|
> **Status 2026-10-02:** dormant. Brief only and unapproved. The subtraction it asks for still needs a measured recall comparison before the flat IR goes.
|
|
|
|
**Status:** brief only, unapproved.
|
|
|
|
## Why now
|
|
|
|
> "we should make sure our code base here doesn't explode. for example we have a custom IR. maybe vine
|
|
> (berkely) or another existing IR (rolf rolles had one) ... I know Ghidra has one we could steal"
|
|
|
|
Two different questions live inside that, and they have opposite answers. Keeping them apart is most of the
|
|
value of this brief.
|
|
|
|
## Question 1, the source IR we already replaced and never retired
|
|
|
|
`semantic/` is **3,218 lines, 16% of the codebase**: a hand-written IR (`ir.py`, `cst.py`) and a flat taint
|
|
engine (`taint.py`), plus the overlay that runs them. `model-grounded-detection` measured that IR against
|
|
Joern's CPG and the result was decisive, **2.2% entailment against 41.3%**, which is why the CPG was
|
|
adopted for the model layer. The flat IR was never removed, and still runs as a proposer in every scan.
|
|
|
|
So the outgrowth is not something we are about to add. It is something already carried.
|
|
|
|
**Vine and P-Code do not help here.** Both are *binary* IRs. Vine lifts executables (BitBlaze, UC Berkeley,
|
|
GPL-2.0, last significant activity 2009), and P-Code lifts machine code. Our source languages are Python,
|
|
PHP, JavaScript and Java, and the source IR we should adopt is the one we already have. The work is
|
|
subtraction, not substitution:
|
|
|
|
- Can the CPG serve the overlay's job at equal or better recall?
|
|
- What does deleting `semantic/`'s IR and taint cost, measured on the pair corpus and both repositories?
|
|
- What has to stay? `obligations/` reads the same facts and is a different analysis.
|
|
|
|
A candidate ~1,000-line deletion with a number attached, which is the only kind worth doing.
|
|
|
|
## Question 2, the abstraction we are missing, where an existing IR is exactly right
|
|
|
|
`c/memory` has produced **zero true positives** and three distinct classes of false one. The reason is
|
|
structural and now stated in the report (Req 5.6): it models unbounded string CALLS, while real C overflows
|
|
are *arithmetic* (an index, a pointer offset, a `memcpy` whose size is computed). Every one of libpng's is,
|
|
and its library code never calls a modelled string API at all.
|
|
|
|
"Can this expression exceed this allocation" is a value question, not a reachability one. **Rolf Rolles'
|
|
GhidraPAL carries a three-valued-logic abstract interpreter over Ghidra P-Code**, with each bit definite 0,
|
|
definite 1, or unknown, and with abstract transformers for `INT_ADD`, `INT_MULT`, `INT_AND`, the comparisons,
|
|
validated against concrete execution in its own tests. That is precisely the shape of analysis the C family
|
|
lacks, and it exists.
|
|
|
|
### The candidates, and why they are not equivalent
|
|
|
|
| | language | IR | analyses | licence | state |
|
|
| --- | --- | --- | --- | --- | --- |
|
|
| **angr** | **Python 3** (+ Rust) | VEX, lifting | CFG recovery, data-dependency, **value-set analysis**, symbolic execution | BSD-2-Clause | actively maintained, ~14.8k commits |
|
|
| **GhidraPAL** | Java | Ghidra P-Code | **three-valued-logic abstract interpreter**, transformers validated against concrete runs | see repo | research code, small |
|
|
| **Vine** | OCaml/C++ | own IL | BitBlaze static analysis | GPL-2.0 | dormant since 2009 |
|
|
|
|
**angr is the strongest candidate and Vine is not one.** Three things decide it:
|
|
|
|
* It is Python. This codebase is Python with `dependencies = []` in the core, and every heavyweight
|
|
capability so far has been reached across a subprocess boundary rather than imported. angr fits that
|
|
pattern as an extra, the way `harnessx` and the tree-sitter grammars already do.
|
|
* Value-set analysis is the abstraction we are missing, by name. "Can this index exceed this allocation"
|
|
is a VSA question, and VSA is abstract interpretation rather than SMT -- which is the choice
|
|
`model-grounded-detection` already made and gave its reasons for.
|
|
* BSD-2-Clause, against Vine's GPL-2.0. This project has a standing rule about never vendoring code
|
|
without a stated licence, and a GPL dependency is a decision about the whole tool rather than about one
|
|
analysis.
|
|
|
|
GhidraPAL stays interesting for a different reason: it is a worked example of the *domain*, not a platform.
|
|
Its TVL bit-vector and its validated transformers for `INT_ADD`, `INT_MULT` and the comparisons are the
|
|
thing to read before writing any abstract domain here, whether the platform underneath is angr or Ghidra.
|
|
|
|
It is also the honest answer to a decision this project already took. `model-grounded-detection` chose
|
|
abstract interpretation over SMT, and chose to build the model from code because execution cannot be
|
|
assumed. A bit-level abstract interpreter over P-Code is *still abstract interpretation* and still static.
|
|
What changes is the artifact: it needs a **built** library rather than its source.
|
|
|
|
## What this brief must decide
|
|
|
|
1. Whether the source-IR subtraction is safe, measured rather than assumed.
|
|
2. Whether the C arithmetic class is worth a second pipeline at all, or whether `c/memory` stays scoped to
|
|
string misuse and says so, which is where task 2.16 left it, deliberately.
|
|
3. If it is worth it: **angr** first, on language, licence and the fact that value-set analysis is the
|
|
named abstraction -- with GhidraPAL read as the worked example of a bit-precise domain rather than as a
|
|
platform. Vine is dormant since 2009 and is not a candidate.
|
|
4. What a second pipeline costs in the one currency this project has been strict about,
|
|
**the number of things that can silently return nothing rather than lines.** This session found three separate quiet failures
|
|
in one PHP scan. A binary pipeline adds a build step, a lifter, and a domain, each of which can produce
|
|
an empty result that looks like a clean one.
|
|
|
|
## The constraint that governs it
|
|
|
|
Nothing here may grow the codebase without a measurement that justifies it, and the module audit
|
|
(`benchmarks/measurements/2026-09-08-module-audit.json`, currently 97 modules with no orphans) is the
|
|
instrument. A brief that ends in "adopt P-Code" and 3,000 new lines while `semantic/` still carries 3,218
|
|
has made the problem worse, not better. **Question 1 should land before Question 2 starts.**
|