mirror of
https://github.com/norandom/OpenUltraSAST.git
synced 2026-10-21 05:59:29 +00:00
72 lines
5.1 KiB
Markdown
72 lines
5.1 KiB
Markdown
# Group 6 implementation and verification
|
||
|
||
The maintainer authorized 6.1–6.4 together on 2026-09-13. A fresh implementer dispatch
|
||
failed with `agent thread limit reached`; the explicit kiro-impl manual fallback applies.
|
||
Reviews below are main-context adversarial reviews, not independent reviewer evidence.
|
||
The design amendment makes measured preparation/discovery costs explicit. Rollout gates
|
||
and the empty default capability registry are unchanged.
|
||
|
||
## Task 6.1 brief
|
||
|
||
Requirements 4.2, 4.3, 4.4 and 7.3; design: Cache and Engine Boundary.
|
||
Backend-owned identities bind readable source paths/bytes, declarations, exclusions,
|
||
frontend/engine versions, overlay implementation and options. Complete graphs require a
|
||
named source census, methods, calls and the dataflow overlay. Loading checks identity and
|
||
streamed graph digest, then issues a disposable copy through the existing CpgResult driver
|
||
contract. Old structural manifests without source paths cannot qualify. Sharded or partial
|
||
graphs cannot qualify. Query locations normalize to repository-relative paths.
|
||
|
||
## Status Report
|
||
- STATUS: READY_FOR_REVIEW
|
||
- TASK: 6.1
|
||
- RED_PHASE_OUTPUT: `/tmp/group6-1-red.log` and `/tmp/group6-1-flag-off.log`: four failures before implementation/with the temporary switch OFF. ON passed; switch removed and five final tests passed.
|
||
- TESTS_RUN: 105 focused tests passed; full suite 1246 passed, 9 skipped (105.31s), followed by the final additional driver integration test and focused rerun. Ruff and mypy passed.
|
||
- EVIDENCE: source-mounted nonroot Docker Joern 4.0.625, network disabled, 3 GiB limit: read 45 JavaScript bytes, census 1 file/4 methods/3 calls, sealed graph loaded through a disposable lease, original digest unchanged after query and cleanup. This is a correctness control, not a latency benchmark.
|
||
- CONCERNS: persistent publication and runner selection belong to 6.2–6.4; this task provides the validated backend lease contract. Main-context review fallback.
|
||
|
||
## Review Verdict
|
||
- VERDICT: APPROVED
|
||
- TASK: 6.1
|
||
- MECHANICAL_RESULTS: focused tests, full regression suite, ruff, mypy and diff whitespace checks passed; no introduced placeholders or secrets.
|
||
- FINDINGS: review repaired unbounded full-graph buffering to streamed hashing/copy; unreadable source walks fail explicitly; single PHP graph census passes through unchanged while sharded graphs cannot seal. Existing driver accepts and releases the leased CpgResult.
|
||
- SUMMARY: Backend identity and isolated leases satisfy task 6.1 within the approved boundary.
|
||
|
||
## Verification Result
|
||
- STATUS: VERIFIED
|
||
- CLAIM_TYPE: TASK
|
||
- CLAIM: Task 6.1 identity and lease behavior, not persistent runner reuse or rollout readiness.
|
||
- EVIDENCE: tests/test_graph_reuse.py, 105 focused passing tests, full suite and real Joern control above; measurement JSON retained in benchmarks/measurements/2026-09-13-graph-lease-control.json.
|
||
- GAPS: Warm push feasibility and independent capability eligibility remain unproven.
|
||
|
||
## Task 6.2 brief and review
|
||
|
||
Requirements 4.1, 4.3, 4.4 and 7.3; design: Cache and Engine Boundary. Private
|
||
0700 cache roots, 0600 files, fixed lock stripes plus a publication lock, streamed payload
|
||
digests, manifest receipts, atomic completed directory publication and size accounting
|
||
(payload plus manifests) implement local storage. Incomplete data is never published as
|
||
complete. A lookup holds a shared lease; eviction requires an exclusive lock and skips
|
||
leased entries. Abandoned private partials count toward the limit and can be reclaimed.
|
||
All lock waits and copying check the caller's absolute deadline; cleanup uses its allowance.
|
||
No graph node mutation, executable deserialization or repository writes are introduced.
|
||
|
||
## Status Report
|
||
- STATUS: READY_FOR_REVIEW
|
||
- TASK: 6.2
|
||
- RED_PHASE_OUTPUT: `/tmp/group6-2-red.log`: seven tests failed with the temporary cache switch OFF. ON passed; switch removed; nine final cache tests passed.
|
||
- TESTS_RUN: 13 cache/audit tests passed, full suite 1256 passed and 9 skipped (104.11s); ruff and mypy passed. Final receipt-validation repair was followed by the 13-test focused rerun.
|
||
- EVIDENCE: concurrent subprocess writers, corrupted payload/manifest, interrupted atomic replace, abandoned partial files, bounded lock contention, leased eviction, unsafe paths and preservation of consumer exceptions.
|
||
|
||
## Review Verdict
|
||
- VERDICT: APPROVED
|
||
- TASK: 6.2
|
||
- MECHANICAL_RESULTS: canonical suite and final focused regression passed; static checks and diff whitespace passed; no new placeholders or secrets.
|
||
- FINDINGS: review added metadata receipt validation and fixed contextmanager exception ownership; lock inodes are retained in 64 bounded stripes to avoid unlink/recreate races. Storage size means bytes of payloads/manifests, not filesystem allocation overhead.
|
||
- SUMMARY: Complete publication or explicit miss is preserved through tested concurrency, corruption and interruption paths.
|
||
|
||
## Verification Result
|
||
- STATUS: VERIFIED
|
||
- CLAIM_TYPE: TASK
|
||
- CLAIM: Task 6.2 bounded local artifact publication and eviction.
|
||
- EVIDENCE: nine cache contract tests and full suite above; production cache implementation, not a mocked storage path.
|
||
- GAPS: Semantic keys and live replay integration follow in 6.3 and 6.4; no warm-latency claim.
|