Files
Open_Ultra_SAST/tests/test_learn_examples.py
T
Marius CiepluchandClaude Opus 5.5 7b81c9ac4e feat(learn): excerpts and the example store (decision-engine 6.1)
learn/excerpt.py: the labelled function at its pin as numbered lines, bounded
(80 lines / 4,000 chars for candidates, 40 / 2,000 for memory examples),
centred on focus lines; advisory ids anywhere and comments with security
wording (labels.security_reason, multilingual) become <redacted>; owner,
owner/name, path and commit ids are replaced; a delta unit appends the
base->head diff (<= 40 lines). C/C++ and other brace languages without a
repo-facts declaration pattern use a brace matcher (346 c_cpp pair rows
had no excerpt without it).

learn/examples.py + `ousast learn memory build`: label + feature record +
excerpt -> `example` rows (no rationale), excerpts as content-addressed
blobs; refuses origin: user and sources outside sources.toml (exit 2);
conditional labels skipped; exit 2 when >10% of a source's recorded
candidates have no excerpt. A fixed side that was read but no longer
declares the labelled function is counted apart (absent_fixed_side): a
label defect, not an unread clone.

plane/memory.py: `example` in KINDS; put_blob/get_blob/blob_names on the
MemoryStore base, so FileStore and MinioStore share them (tested on both,
MinIO through the fake object client).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01EmM1j46qgKMh3zqD1QMwEo
2026-10-01 09:45:17 +02:00

158 lines
7.9 KiB
Python

"""The example store (learned-decision-engine design 4.2, task 6.1): label + feature record + excerpt -> ``example``
rows, the refusals, the 10% unread-excerpt failure, and content-addressed blobs on both backends."""
from __future__ import annotations
import hashlib
import json
from collections.abc import Iterator, Mapping, Sequence
from pathlib import Path
from typing import Any
import pytest
from test_plane_memory import FakeObjects
from openultrasast.cli import main
from openultrasast.learn.examples import (
ExampleBuildError,
build_examples,
label_pin,
load_examples,
record_key,
records_by_key,
)
from openultrasast.learn.features import Part, quick_part, record
from openultrasast.learn.labels import Source, Sources
from openultrasast.plane.memory import FileStore, MemoryStore, MemoryStoreError, MinioStore
PIN = "0123456789abcdef0123456789abcdef01234567"
SOURCES = Sources(
(Source("pairs", "pairs", (), (), "2026-09-30", "development"), Source("population-v1", "population", (), (), "2026-09-25", "spent")),
frozenset(),
{},
Path("sources.toml"),
)
CODE = {
"vulnerable": ["def handler(request):", " # CVE-2021-1234 fixed later", " return run(request.args['q'])", ""],
"fixed": ["def handler(request):", " return run(quote(request.args['q']))", ""],
}
@pytest.fixture(params=["file", "fake-minio"])
def store(request: pytest.FixtureRequest, tmp_path: Path) -> Iterator[MemoryStore]:
yield FileStore(tmp_path / "memory") if request.param == "file" else MinioStore(FakeObjects("works"), "bucket", "p")
def label(**kw: Any) -> dict[str, Any]:
base = {
"candidate": "app.py::handler", "family": "injection", "label": 1, "source": "population-v1", "source_ref": "case-1",
"unit": "pin", "weight": 1.0, "split": "population-v1", "group": "acme/webapp", "repo": "https://github.com/acme/webapp",
"language": "python", "created": "2026-09-30", "pin": PIN, "pin_role": "vulnerable", "frameworks": ["flask"],
"conditional": None, "direction": None,
} # fmt: skip
return {**base, **kw}
def feature(lab: Mapping[str, Any], unit: str = "pin") -> dict[str, Any]:
parts = {"quick": quick_part([("r1", "enabled")], {})}
if unit == "delta":
parts["delta"] = Part("ran", {"delta.novelty": "new", "delta.changed_lines": 1, "delta.sanitizer_removed": True})
out = record(str(lab["candidate"]), str(lab["family"]), "python", "static", parts, unit=unit)
return {**out, "repo": lab["repo"], "pin": label_pin(lab)}
def lines_of(lab: Mapping[str, Any], role: str) -> Sequence[str] | None:
return CODE[role]
def test_example_rows_join_label_record_and_excerpt(store: MemoryStore) -> None:
pos, neg = label(), label(label=0, pin_role="fixed", pin="f" * 40)
records = records_by_key([feature(pos), feature(neg)])
build = build_examples([pos, neg], records, lines_of, sources=SOURCES, store=store)
assert build.summary()["examples"] == 2 and not build.failing()
stored = load_examples(store)
assert sorted(e.label for e in stored) == [0, 1] and {e.group for e in stored} == {"acme/webapp"}
row = next(r.row for r in store.rows(kind="example") if r.row["label"] == 1)
assert row["kind"] == "example" and row["frameworks"] == ["flask"] and "rationale" not in row
text = store.get_blob("excerpts", row["excerpt_sha"])
assert text is not None and hashlib.sha256(text).hexdigest() == row["excerpt_sha"]
assert b"CVE-2021" not in text
assert "acme" not in text.decode() and "app.py" not in text.decode()
def test_delta_units_carry_the_diff(store: MemoryStore) -> None:
lab = label(unit="delta", direction="introduce")
build = build_examples([lab], records_by_key([feature(lab, "delta")]), lines_of, sources=SOURCES, store=store)
row = build.rows[0]
text = store.get_blob("excerpts", row["excerpt_sha"])
assert text is not None and b"\ndiff:\n@@" in text and b"+ return run(request.args['q'])" in text
def test_user_origin_and_unlisted_sources_are_refused() -> None:
with pytest.raises(ExampleBuildError, match="origin: user"):
build_examples([label(origin="user")], {}, lines_of, sources=SOURCES)
with pytest.raises(ExampleBuildError, match="not in"):
build_examples([label(source="population-v3")], {}, lines_of, sources=SOURCES)
def test_conditional_and_unrecorded_labels_never_become_examples() -> None:
rows = [label(conditional="signal_at_tip_not_base", label=0), label(source="pairs", pin="", source_ref="p1")]
build = build_examples(rows, {}, lines_of, sources=SOURCES)
assert build.rows == [] and build.skipped == {"conditional label (condition not evaluated)": 1}
assert build.sources["pairs"].no_record == 1
def test_more_than_ten_percent_without_excerpt_fails_the_source() -> None:
labs = [label(candidate=f"app.py::f{i}", source_ref=f"c{i}") for i in range(10)] + [label()]
records = records_by_key([feature(lab) for lab in labs])
build = build_examples(labs, records, lines_of, sources=SOURCES) # f0..f9 are not declared in CODE: no excerpt
assert build.sources["population-v1"].no_excerpt == 10 and build.failing() == ["population-v1"]
ok = build_examples([label()], records, lines_of, sources=SOURCES)
assert ok.failing() == []
def test_pair_pins_are_stable_and_distinct_per_side() -> None:
vuln, fixed = label(source="pairs", pin="", source_ref="p1"), label(source="pairs", pin="", source_ref="p1", pin_role="fixed")
assert label_pin(vuln) != label_pin(fixed) and len(label_pin(vuln)) == 40 and label_pin(vuln) == label_pin(dict(vuln))
assert label_pin(label()) == PIN
key = record_key(vuln["repo"], label_pin(vuln), "app.py::handler", "injection", "pin")
assert key[0] == "github.com/acme/webapp"
def test_blobs_are_content_addressed_on_both_backends(store: MemoryStore) -> None:
sha = store.put_blob("excerpts", b"x = 1\n")
assert sha == hashlib.sha256(b"x = 1\n").hexdigest() and store.get_blob("excerpts", sha) == b"x = 1\n"
assert store.put_blob("excerpts", b"x = 1\n") == sha and store.blob_names("excerpts") == [sha]
keyed = store.put_blob("embeddings/openai__text-embedding-3-small", b'{"v": 1}', name=sha)
assert keyed == sha and store.get_blob("embeddings/openai__text-embedding-3-small", sha, verify=False) == b'{"v": 1}'
assert store.get_blob("excerpts", "0" * 64) is None
for bad in ("repos", "../x", "facts"):
with pytest.raises(MemoryStoreError):
store.put_blob(bad, b"x")
with pytest.raises(MemoryStoreError):
store.get_blob("excerpts", "not-a-sha")
def test_a_changed_blob_is_dropped_not_served(tmp_path: Path) -> None:
store = FileStore(tmp_path / "m")
sha = store.put_blob("excerpts", b"a\n")
(tmp_path / "m" / "excerpts" / f"{sha}.txt").write_bytes(b"tampered\n")
assert store.get_blob("excerpts", sha) is None and store.blob_names("excerpts") == []
def test_cli_build_writes_examples_and_exits_2_on_refusal(tmp_path: Path, capsys: pytest.CaptureFixture[str]) -> None:
labels = tmp_path / "labels.jsonl"
labels.write_text(json.dumps(label(origin="user")) + "\n")
assert main(["learn", "memory", "build", "--labels", str(labels), "--dry-run"]) == 2
assert "origin: user" in capsys.readouterr().err
def test_a_fixed_side_without_the_function_is_a_label_defect_not_an_unread_side() -> None:
fixed = label(label=0, pin_role="fixed", pin="f" * 40)
moved = {"vulnerable": CODE["vulnerable"], "fixed": ["def guard(request):", " return True"]}
build = build_examples([fixed], records_by_key([feature(fixed)]), lambda lab, role: moved[role], sources=SOURCES)
count = build.sources["population-v1"]
assert count.absent_fixed_side == 1 and count.no_excerpt == 0 and build.failing() == []
unread = build_examples([fixed], records_by_key([feature(fixed)]), lambda lab, role: None, sources=SOURCES)
assert unread.sources["population-v1"].unread == 1 and unread.failing() == ["population-v1"]