mirror of
https://github.com/norandom/OpenUltraSAST.git
synced 2026-10-16 03:49:26 +00:00
Marius CiepluchandClaude Opus 5.5
b9afb66250
Deletes harness_ext.py and hunter_harness.py with their HarnessX-only tests (the judge path, verify_judge.py, went in task 5). The harnessx extra, its mypy override and its uv.lock entries are removed (uv lock drops only packages; no remaining version changes). The conftest fixture becomes assert_cold_import; test_gate's two never-import checks become one allow-list (stdlib, openultrasast, yaml) over the governance planes' module-level imports, and the skipped live-extra tolerance test is deleted. Audit rows for the two modules are removed, stage_processors is reworded, and the module-audit manifest is regenerated (no orphan). test_removed_plane_references implements Req 2.4 over src, tests and pyproject.toml: a match must carry a `retired 2026-..` tag (the spec's own slug is not counted). The README part is a strict xfail until task 8 rewrites the README's plane sections. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01EmM1j46qgKMh3zqD1QMwEo
55 lines
2.4 KiB
Python
55 lines
2.4 KiB
Python
"""Requirement 2.4 of the removal spec: the removed agentic plane is named only in its retirement notes.
|
|
|
|
A case-insensitive search of ``src/``, ``tests/``, ``pyproject.toml`` and the README may match only lines tagged
|
|
``retired 2026-..``: the retired-key table and the one warning in ``config.py``, the retirement tests, and the README's
|
|
plane section. The spec's own slug (its directory name, the equality instrument's file name) is a citation of the
|
|
removal, not a use of the plane, and is not counted. The pattern is built at runtime so this file does not match it.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
_NAME = "harness" + "x"
|
|
_PATTERN = re.compile(_NAME, re.IGNORECASE)
|
|
_SPEC_SLUG = re.compile(_NAME + r"[-_]removal", re.IGNORECASE)
|
|
_TAG = re.compile(r"retired 2026-\d\d-\d\d", re.IGNORECASE)
|
|
|
|
|
|
def _untagged(paths: list[Path]) -> list[str]:
|
|
offenders = []
|
|
for path in paths:
|
|
try:
|
|
text = path.read_text(encoding="utf-8")
|
|
except (UnicodeDecodeError, OSError):
|
|
continue
|
|
for number, line in enumerate(text.splitlines(), 1):
|
|
if _PATTERN.search(_SPEC_SLUG.sub("", line)) and not _TAG.search(line):
|
|
offenders.append(f"{path.relative_to(ROOT)}:{number}: {line.strip()[:120]}")
|
|
return offenders
|
|
|
|
|
|
def _tree(*roots: str) -> list[Path]:
|
|
return sorted(p for root in roots for p in (ROOT / root).rglob("*") if p.is_file() and "__pycache__" not in p.parts)
|
|
|
|
|
|
def test_no_harnessx_outside_retirement_notes() -> None: # the Req 2.4 check itself, retired 2026-09-30
|
|
offenders = _untagged([*_tree("src", "tests"), ROOT / "pyproject.toml"])
|
|
assert offenders == [], "the removed plane is named outside a tagged retirement note:\n" + "\n".join(offenders)
|
|
|
|
|
|
def test_the_retirement_notes_exist() -> None:
|
|
"""The search is not vacuous: the one warning and the retired keys are where the design puts them."""
|
|
config = (ROOT / "src/openultrasast/config.py").read_text()
|
|
assert _PATTERN.search(config) and _TAG.search(config)
|
|
|
|
|
|
@pytest.mark.xfail(strict=True, reason="the README's plane sections are rewritten in task 8; drop this mark there")
|
|
def test_the_readme_names_the_removed_plane_only_in_its_retirement_note() -> None:
|
|
offenders = _untagged([ROOT / "README.md"])
|
|
assert offenders == [], "\n".join(offenders)
|